[LDCad] Part Snapping missing/errors

[Florent Faramond]

Hello Roland, 

I don't have permission to push on the git as recommended in the CONTRIBUTING.md.
Can you give me the permission or is there another way?

[Roland Melkert]

I don't have permission to push on the git as recommended in the CONTRIBUTING.md.

The contributing.md file wasn't really supposed to be part of github yet, as it is a work in progress (references the unreleased 1.7 Beta version etc).

 I just forgot to uncheck it when pushing one of the other updates.

Anyhow it talks about cloning the repository, but this should be forking when you want to contribute.

I uploaded a newer version.

[N. W. Perry]

Bottom snap info is wrong on the 1x2 hinge parts 2429 and 2430 (was the origin moved recently or something?).

2429 should be:

Code:

0 !LDCAD SNAP_CYL [gender=F] [caps=one] [secs=S 6 4] [pos=-20 8 10] [grid=C 2 1 20 0]

2430 should be:

Code:

0 !LDCAD SNAP_CYL [gender=F] [caps=one] [secs=S 6 4] [pos=20 8 10] [grid=C 2 1 20 0]

Also, part 60594 needs:

Code:

0 !LDCAD SNAP_FGR [genderOfs=F] [seq=60] [radius=2] [pos=-34 34 2]
0 !LDCAD SNAP_FGR [genderOfs=F] [seq=60] [radius=2] [pos=34 34 2]
0 !LDCAD SNAP_FGR [genderOfs=F] [seq=72] [radius=2] [pos=0 8 4] [ori=0 1 0 -1 0 0 0 0 1]
0 !LDCAD SNAP_FGR [genderOfs=F] [seq=72] [radius=2] [pos=0 60 4] [ori=0 1 0 -1 0 0 0 0 1]

[Roland Melkert]

Bottom snap info is wrong on the 1x2 hinge parts 2429 and 2430 (was the origin moved recently or something?).

Apparently I missed these errors while mass removing some INCLUDE meta's

I will correct this in the next GITHUB update

[Jaco van der Molen]

Apparently I missed these errors while mass removing some INCLUDE meta's

I will correct this in the next GITHUB update

Is https://github.com/RolandMelkert/LDCadShadowLibrary/ still up and running?
I see last change is about 5 months ago?

[Roland Melkert]

Is https://github.com/RolandMelkert/LDCadShadowLibrary/ still up and running?
I see last change is about 5 months ago?

Unless github has shutsdown it should still be there

I haven't done much with shadow information myself lately, I will pick it up at some point though.

I'm still hoping others will contribute too, as the LDraw library releases seem to be every other week these days

[Jaco van der Molen]

Unless github has shutsdown it should still be there

I haven't done much with shadow information myself lately, I will pick it up at some point though.

I'm still hoping others will contribute too, as the LDraw library releases seem to be every other week these days

OK, great. 
I very much like to contributes, but it still unclear to me how.
I know how to add snap info, but building the right header and submitting to Github is also unclear.
(sorry)

Can you or someone make a clear instruction on how the header should be and make a little guide how to push (?) to Github

[Roland Melkert]

OK, great. 
I very much like to contributes, but it still unclear to me how.
I know how to add snap info, but building the right header and submitting to Github is also unclear.
(sorry)

Can you or someone make a clear instruction on how the header should be and make a little guide how to push (?) to Github

Missed this post, sorry.

Headers are generated 95% automatically in 1.7Beta1, see the repo's contributing.md for more info.

as for how to work with github this is still a bit of learning curve, see this thread for some ongoing notes/tips:
https://forums.ldraw.org/thread-28261.html

[Jaco van der Molen]

OK, I uploaded 60481a.dat to my copy of the fork (I believe this is called so).
Can you see if this is OK?
If so, I have a few more to add I think.

[Roland Melkert]

OK, I uploaded 60481a.dat to my copy of the fork (I believe this is called so).
Can you see if this is OK?
If so, I have a few more to add I think.

I can't find it on
https://github.com/jacovandermolen/LDCad...main/parts

Did you commit and push?

I also noticed your fork is up-to-date with my last changes on my repo, did you manually sync? If not I'm a bit confused as I've read on multiple places people need to sync forks with the upstream manually.

edit:
Weird there is a s\60481s01.dat I did in 2014, but that subpart seems to be unused now.
So I copy/pasted that file to 60481as01.dat which 1.7Beta1 will automatically correct to this:

Code:

0 LDCad shadow info for "~Slope Brick 65  2 x  1 x  2 with Symmetric Stud Holder without Outside Faces"

0 Author: LDCad Shadow Library
0 !LICENSE CC BY-SA 4.0, see LICENSE.md

0 !HISTORY 2014-02-19 {Roland Melkert} Initial info for s\60481s01.dat
0 !HISTORY 2024-05-21 {Roland Melkert} Moved to s\60481as01.dat

0 !LDCAD SNAP_CYL [gender=F] [caps=one] [secs=S 6 44] [pos=0 48 0]
0 !LDCAD SNAP_CYL [gender=F] [caps=one] [secs=S 6 4] [pos=0 48 -20]

[Jaco van der Molen]

I can't find it on
https://github.com/jacovandermolen/LDCad...main/parts

Did you commit and push?

I also noticed your fork is up-to-date with my last changes on my repo, did you manually sync? If not I'm a bit confused as I've read on multiple places people need to sync forks with the upstream manually.

When I upload to my copy (the fork?) of your library, I need to hit Commit.
I do not see a Push option.
I committed 60481a again.
Then I created a pull request.

I now see this at my Github:

Code:

This branch is 1 commit ahead of RolandMelkert/LDCadShadowLibrary:main.

Can you pull my file to yours?

[Roland Melkert]

When I upload to my copy (the fork?) of your library, I need to hit Commit.
I do not see a Push option.
I committed 60481a again.
Then I created a pull request.

I now see this at my Github:

Code:

This branch is 1 commit ahead of RolandMelkert/LDCadShadowLibrary:main.

Can you pull my file to yours?

Ah you are editing on github itself? In that case a commit and a pull request should do.

I commented on your pr on github, but like I wrote there the file is not needed I committed the fix I gave above.

github can be VERY confusing indeed, I'm still finding my way in it too (I only use svn on my non public stuff as I'm a single developer, only really starting to use git with the shadow lib).

Anyhow the most used way of doing things is:

1 Fork the repo you want to contribute to (like you did).
2 Clone the fork to your local PC
3 Start a new branch inside your clone and switch to it (make it the working copy).
4 Edit / add file using your favourite editor or LDCad it self.
5 Commit your changes now and then.
6 Push all your changes/commits to your fork when your done / want to make it public.
7 When done and you want to contribute your changes made so far,, create a pull request using the custom branch you made.
8 Once you made a pull request any additional commits to the same brache will automatically become part of the open PR, but this is commonly discouraged un github. So you probably want to go back to step 3.

That said it is also perfectly fine to just add stuff on github itself like you did with 60481, so feel free to add stuff to your open PR. But if you decide to go the other way let me know so I can close the PR.

[Roland Melkert]

I've processed things posted here up to message #213

You'll find the latest version of the library at
https://github.com/RolandMelkert/LDCadShadowLibrary

To use it just download the code (green button) and point LDCad to it using it's search location dialog. (needs a rename to .csl for LDCad 1.6 and older).

Thanks to all who posted

[Jaco van der Molen]

I've processed things posted here up to message #213

You'll find the latest version of the library at
https://github.com/RolandMelkert/LDCadShadowLibrary

To use it just download the code (green button) and point LDCad to it using it's search location dialog. (needs a rename to .csl for LDCad 1.6 and older).

Thanks to all who posted

Thank you!

[Jaco van der Molen]

Ah you are editing on github itself? In that case a commit and a pull request should do.

I commented on your pr on github, but like I wrote there the file is not needed I committed the fix I gave above.

github can be VERY confusing indeed, I'm still finding my way in it too (I only use svn on my non public stuff as I'm a single developer, only really starting to use git with the shadow lib).

Anyhow the most used way of doing things is:

1 Fork the repo you want to contribute to (like you did).
2 Clone the fork to your local PC
3 Start a new branch inside your clone and switch to it (make it the working copy).
4 Edit / add file using your favourite editor or LDCad it self.
5 Commit your changes now and then.
6 Push all your changes/commits to your fork when your done / want to make it public.
7 When done and you want to contribute your changes made so far,, create a pull request using the custom branch you made.
8 Once you made a pull request any additional commits to the same brache will automatically become part of the open PR, but this is commonly discouraged un github. So you probably want to go back to step 3.

That said it is also perfectly fine to just add stuff on github itself like you did with 60481, so feel free to add stuff to your open PR. But if you decide to go the other way let me know so I can close the PR.

I see. But now I at least know how to contribute ;-)

[Roland Melkert]

I see. But now I at least know how to contribute ;-)

You can also make a new branch while you committing your local changes (using main).

Avoiding committing to the main branch will probably also prevent those 'x commits behind/in front ...' messages on your fork's page. Which makes it easier to keep the fork:main insync with shadowlib:main.

[Fredrik Hareide]

You can also make a new branch while you committing your local changes (using main).

Avoiding committing to the main branch will probably also prevent those 'x commits behind/in front ...' messages on your fork's page. Which makes it easier to keep the fork:main insync with shadowlib:main.

Yep, making a branch is crucial before making the PR. Also it might be smart to do new branches for each commit. But might also be excessive.

[Jaco van der Molen]

If all went well, I just contributed 10 new files with missing/adjusted snap info to Github.

[Roland Melkert]

If all went well, I just contributed 10 new files with missing/adjusted snap info to Github.

Sorry but some of the headers are wrong, are you using the automatic header feature of 1.7 beta 1?

You also seem to be changing old versions of files as you undid some of Fredrik's changes.

It is probably easiest if I correct/merge things and close the pr.

Afterwards you can sync your fork's main before starting a new branch in it like described above.

Also it might look harder but, imho, it's actually easier to use the local repository approach instead of the uploading files one.

You can use github desktop for it if you don't already have any git tools installed locally.

ps: file upload also seems to mess with line endings

[Roland Melkert]

upload also seems to mess with line endings

I fixed all, but in the end it took me much longer then it should, I also accidentality deleted some files I didn't want to merge in main (seems it merges deletions too   )

Still figuring this stuff out too.

[Jaco van der Molen]

Sorry but some of the headers are wrong, are you using the automatic header feature of 1.7 beta 1?

You also seem to be changing old versions of files as you undid some of Fredrik's changes.

It is probably easiest if I correct/merge things and close the pr.

Afterwards you can sync your fork's main before starting a new branch in it like described above.

Also it might look harder but, imho, it's actually easier to use the local repository approach instead of the uploading files one.

You can use github desktop for it if you don't already have any git tools installed locally.

ps: file upload also seems to mess with line endings

OK, I will try. I want to contribute, but it is hard. Not your mistake!

I don't understand I change old versions. I have updated my LDraw parts en downloaded the latest repository from Github before changing or adding anything.

My mistake is not using 1.7, sorry for that.

[Roland Melkert]

My mistake is not using 1.7, sorry for that.

You can enable it  in 'prefs/edit/part editing'.

It will automatically add/reorder the shadow header lines upon file save.

Just be sure to double check as it will add a history line with a TODO text when the current date is different than the one in the last history line or if that line is by another author.

[Roland Melkert]

I've added most 2020-02 and 2020-03 parts to the repo while testing Beta 2  

You can update LDCad 1.7 shadow by downloading the code from
https://github.com/RolandMelkert/LDCadShadowLibrary
and point LDCad to it using prefs/LDraw search paths (replace offLibShadow.csl with LDCadShadowLibrary-main.zip)

For use in 1.6 you need to rename it to .csl first.

[N. W. Perry]

Part 86996 needs bottom snap info:

Code:

0 !LDCAD SNAP_CYL [gender=F] [caps=one] [secs=S 6 12] [pos=0 16 0]

[Roland Melkert]

Part 86996 needs bottom snap info:

Thanks, I added slightly different:

Code:

0 !LDCAD SNAP_CYL [gender=F] [caps=none] [secs=S 6 12   R 4 8] [pos=0 16 0]

This accounts for the hole in the stud.

I also added some other obvious missing anti-studs etc to some of the 'sorted bricks' tree.

Latest version is on github.