What requires a HOLD vote on the Parts Tracker

Thread Rating:
  • 0 Vote(s) - 0 Average
  • 1
  • 2
  • 3
  • 4
  • 5

What requires a HOLD vote on the Parts Tracker
#1
We've created this new forum that is only viewable by PT Authors and Reviewers to allow candid discussions regarding Parts Tracker issues. To kick things off, there has been some internal discussion about what, exactly should require a HOLD vote for a part.

Since I'm the one posting this, I'll start with my suggestions:

Things the should require a HOLD:
- Wrong part number
- Wrong or questionable origin
- Invalid syntax
- Blatantly wrong geometry

Things that should generate a warning but not a HOLD:
- Small gaps
- Wrong KEYWORDS or CATEGORY
- Semantics issues like, this should be a subpart
- Anything that the PT Admin can fix (e.g. Header issues)
- Minor color problems
- Basically anything that can be fixed after initial release without breaking models that use the part.

PT Admin shall have the final say on all Parts issues.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#2
Officially we have only the outdated L3P error list:

http://www.ldraw.org/library/tracker/ref/l3pmsg/

while most of us use the output of Datheader (the following list was kindly provided by Mike Heidemann, author of the prog):


1    ERROR    Embedded POV Code found.    HOLD
2    ERROR    '0 WRITE' found. - HOLD
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD
4    ERROR    '0 ROTATION' found.    HOLD
5    ERROR    '0 COLOR' found.    HOLD
6    ERROR    Incorrect use of only '0' for comments. Should be '0 //' instead.
7    ERROR    Not all used colors in LDConfig.ldr.    HOLD
8    ERROR    Matrix all zero found.    HOLD
9    ERROR    Identical vertices found.    HOLD
10    ERROR    Colinear vertices found.    HOLD
11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD
16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.
21    ERROR    Some keywords are also in part description.    HOLD
22    ERROR    Filename does not matches filetitle.    HOLD
23    ERROR    Author real name is not set.
24    ERROR    Author user name is not set.
25    ERROR    BFC is not set.    HOLD
26    ERROR    License is not set.    HOLD
27    ERROR    Part type is not set.    HOLD
28    ERROR    Primitives needs to have CCW winding.    HOLD
29    ERROR    Use of !KEYWORDS is not allowed for this part type.    HOLD
30    ERROR    Part description contains Tab character.    HOLD
31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.
36    ERROR    High-res primitive has to start with '48\'.    HOLD
37    ERROR    Description for primitives should not start with '_' or '~'.    HOLD
38    ERROR    Filename for parts, shortcuts and primitives should not start with '48\' or 's\'.    HOLD
39    ERROR    Filename for subparts has to start with 's\'.    HOLD
40    ERROR    Description for subparts has to start with '~'.    HOLD
41    ERROR    Description for subparts should not start with '_' or '='.
42    ERROR    Description for parts should not start with '_' or '='.
43    ERROR    Description for shortcuts and/or physical_colour parts has to start with '_'.    HOLD
44    ERROR    Filename for shortcuts contains usually a 'c' or 'd'.
45    ERROR    Extension has to be .dat    HOLD
46    ERROR    Special characters in description not allowed.    HOLD
47    ERROR    Lines do not end with <CR><LF>.
48    ERROR    Author !HISTORY entry has no brackets.
49    ERROR    Not scalable primitive is scaled.
50    ERROR    primitive is scaled not only in Y direction.
51    ERROR    First line after BFC INVERTNEXT isn't linetype 1.
52    ERROR    Problem with the RGB value.
53    ERROR    '~Moved to' file used.
54    ERROR    Wrong BFC command found.
55    ERROR    Some keywords are used twice in KEYWORDS section.    HOLD
56    ERROR    'Minifig Accessory' found in part description.
57    ERROR    'Figure Accessory' found in part description.
58    WARNING    'INVERTNEXT' used although not necessary.
59    WARNING    TJunktion detected.
60    ERROR    Wrong brackets around username used. Only [] is allowed
61    ERROR    Description for alias parts should start with '='
62    ERROR    Description for Physical_Colour parts should mention the used colors
63    ERROR    Only linetype 0 and 1 are allowed in Physical_Colour parts.
64    ERROR    Wrong color (16 or/and 24) used for Physical_Colour part
65    ERROR    Only linetype 0 and 1 are allowed in Alias parts.
66    ERROR    Only one (1) linetype 1 is allowed in Alias parts.
67    ERROR    Only color 16 is allowed in Alias parts.
68    ERROR    Alias needs to be mentioned in the comments in the form 'Alias of partnumber'.
69    ERROR    Mentioned part number in the alias comment is wrong.
70    WARNING    Origin is outside the Boundingbox.
71    ERROR    American English words used in part description.
72    WARNING    Too much empty lines at the end of the file.
73    WARNING    Mirrored studs detected.
74    WARNING    Flat subfile scaled in flat direction
75    ERROR    Optional line with same vertices than line found.
76    ERROR    Leading or trailing zeros found.
77    ERROR    Overlapping triangle found.
78    ERROR    Lines with wrong number of arguments found.
79    WARNING    Filename ending does not match declared LDRAW_ORG file type.
80    ERROR    Moved To setnumber with Extension    HOLD
81    WARNING    Filename ending does not match declared LDRAW_ORG part type qualifier.


w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#3
(2017-12-08, 20:51)Willy Tschager Wrote: while most of us use the output of Datheader (the following list was kindly provided by Mike Heidemann, author of the prog):

While I like DATHeader, it's Windows only. I'd like to see a browser based solution. Ultimately, I'd like the PT to check this errors automatically. Both of these solutions are a long way off unless we get a volunteer coder to help us out.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#5
(2017-12-08, 20:58)Orion Pobursky Wrote:
(2017-12-08, 20:51)Willy Tschager Wrote: while most of us use the output of Datheader (the following list was kindly provided by Mike Heidemann, author of the prog):

While I like DATHeader, it's Windows only. I'd like to see a browser based solution. Ultimately, I'd like the PT to check this errors automatically. Both of these solutions are a long way off unless we get a volunteer coder to help us out.

I could possibly help with this.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#8
(2017-12-09, 14:18)Santeri Piippo Wrote:
(2017-12-08, 20:58)Orion Pobursky Wrote: While I like DATHeader, it's Windows only. I'd like to see a browser based solution. Ultimately, I'd like the PT to check this errors automatically. Both of these solutions are a long way off unless we get a volunteer coder to help us out.

I could possibly help with this.

For sure? I'd welcome this.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#30
Next bunch:

6    ERROR    Incorrect use of only '0' for comments. Should be '0 //' instead.
7    ERROR    Not all used colors in LDConfig.ldr.    HOLD
8    ERROR    Matrix all zero found.    HOLD
9    ERROR    Identical vertices found.    HOLD
10    ERROR    Colinear vertices found.    HOLD
Reply
RE: What requires a HOLD vote on the Parts Tracker
#31
> 6    ERROR    Incorrect use of only '0' for comments. Should be '0 //' instead.

Should produce a warning - obviously nothing else: http://www.ldraw.org/article/218.html#lt0

7    ERROR    Not all used colors in LDConfig.ldr.    HOLD

A HOLD is too strict because of the direct color: http://www.ldraw.org/article/218.html#colours

8    ERROR    Matrix all zero found.    HOLD
9    ERROR    Identical vertices found.    HOLD
10  ERROR  Colinear vertices found.    HOLD

Agree.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#32
6 - Change to 0 // style comment. Empty line if only 0 and nothing behind
7 - Prompt user. Must allow direct colors for patterned parts or stickers.
8 - Prompt. Can be auto-corrected for flat primitives, but there is 50% chance of wrong BFC
9 - If type 2 or 3, auto correct (delete line). If type 4 and concerns two consecutive vertices, convert to type 3, otherwise prompt. If type 5 and first two vertices the same, delete line, otherwise prompt.
10 - If type 4: split into 2 triangles, otherwise prompt
Reply
RE: What requires a HOLD vote on the Parts Tracker
#33
Bear in mind that direct colours are only allowed for pattern and sticker geometry:

http://www.ldraw.org/article/512.html#colours

So it's still not allowed in (for example) shortcuts.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#34
(2017-12-18, 20:17)Travis Cobbs Wrote: Bear in mind that direct colours are only allowed for pattern and sticker geometry:

http://www.ldraw.org/article/512.html#colours

So it's still not allowed in (for example) shortcuts.
Indeed. Edited my message above for more precision.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#35
(2017-12-17, 21:06)Willy Tschager Wrote: Next bunch:

6    ERROR    Incorrect use of only '0' for comments. Should be '0 //' instead.
7    ERROR    Not all used colors in LDConfig.ldr.    HOLD
8    ERROR    Matrix all zero found.    HOLD
9    ERROR    Identical vertices found.    HOLD
10    ERROR    Colinear vertices found.    HOLD

Any more opinions on this?

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#36
Here we go:

11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD
Reply
RE: What requires a HOLD vote on the Parts Tracker
#37
(2017-12-26, 17:48)Willy Tschager Wrote: Here we go:

11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD

11 Autocorrect
12 Prompt user
13 Prompt user
14 Prompt user (guess this is about 16 for edges or 24 for triangles, quads, prims)
15 Prompt user
Reply
RE: What requires a HOLD vote on the Parts Tracker
#38
(2017-12-26, 17:51)Willy Tschager Wrote:
(2017-12-26, 17:48)Willy Tschager Wrote: Here we go:

11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD

11 Autocorrect
12 Prompt user
13 Prompt user
14 Prompt user (guess this is about 16 for edges or 24 for triangles, quads, prims)
15 Prompt user

12 can be auto-correct (via split into triangles) as well. 
13 can be auto-corrected but the user should be warned
Reply
RE: What requires a HOLD vote on the Parts Tracker
#40
(2017-12-27, 0:03)Orion Pobursky Wrote:
(2017-12-26, 17:51)Willy Tschager Wrote: 11 Autocorrect
12 Prompt user
13 Prompt user
14 Prompt user (guess this is about 16 for edges or 24 for triangles, quads, prims)
15 Prompt user

12 can be auto-correct (via split into triangles) as well. 
13 can be auto-corrected but the user should be warned

12 Sure, but there are always two ways to split it and I'd like to have control of it.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#41
No, there is only one way of splitting a concave quad!
Reply
RE: What requires a HOLD vote on the Parts Tracker
#42
(2017-12-27, 10:37)Philippe Hurbain Wrote: No, there is only one way of splitting a concave quad!

Upps! Had coplanar quad in mind.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#43
(2017-12-27, 10:37)Philippe Hurbain Wrote: No, there is only one way of splitting a concave quad!

Yup. LDDP does this if asked.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#39
11 - Prompt. Any auto correction could result in wrong BFC
12 - Split into two triangles
13 - Prompt. At first sight, can be solved by splitting into two triangles, but can mess up condlines
14 - Autocorrect. Type 2 or 5 must be color 24, type 1, 3 or 4 in color 24 must be changed to color 16
15 - Prompt.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#44
(2017-12-27, 9:40)Philippe Hurbain Wrote: 11 - Prompt. Any auto correction could result in wrong BFC
12 - Split into two triangles
13 - Prompt. At first sight, can be solved by splitting into two triangles, but can mess up condlines
14 - Autocorrect. Type 2 or 5 must be color 24, type 1, 3 or 4 in color 24 must be changed to color 16
15 - Prompt.

For 13, what you mentioned and the fact that if the quad is very non-coplainer then it should probably be fixed and not just split.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#45
(2017-12-26, 17:48)Willy Tschager Wrote: Here we go:

11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD

Are we done with these?

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#46
Your turn:

16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#47
(2018-01-04, 18:17)Willy Tschager Wrote: Your turn:

16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.

I can't find anything in the spec that forbids 18,19,20. 19 maybe warn but programs should strip these leading spaces anyway.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#48
(2018-01-04, 18:40)Orion Pobursky Wrote:
(2018-01-04, 18:17)Willy Tschager Wrote: Your turn:

16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.

I can't find anything in the spec that forbids 18,19,20. 19 maybe warn but programs should strip these leading spaces anyway.

Strike that for 20. Keyword line length is spec'd to 80 chars max. I think we should revised the spec to remove this requirement.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#51
(2018-01-04, 18:40)Orion Pobursky Wrote:
(2018-01-04, 18:17)Willy Tschager Wrote: Your turn:

16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.

I can't find anything in the spec that forbids 18,19,20. 19 maybe warn but programs should strip these leading spaces anyway.

18 Good catch. On the other hand we have a:

!HELP (Authors should constrain themselves to a 50-character limit to keep the text readable.)

which gives a good indication that we should keep an eye on for example:

11568p01.dat - Animal Squirrel with Black Nose, Mouth and Eyes with Eyelashes and Reddish Brown Face Decorations Pattern
u9310c02.dat - Fabuland House Block with Blue Door and 2 Blue Round Windows with One Semicircular and Three Sextant Panes Panes (Complete)


w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#52
(2018-01-04, 18:17)Willy Tschager Wrote: Your turn:

16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.

16    Autocorrect
17    Prompt
18    Prompt
19    Autocorrect
20    Prompt

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#53
Quote:19    WARNING    Maybe leading spaces in part description.
This is a complex one. DH takes care of trying to keep part length sorting OK, adding a double space in front of length numbers with only one digit in integer part, removing double space everywhere otherwise. But sometimes we don't want that (because the number is not actually a length) so user needs some control.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#55
Next one:

21    ERROR    Some keywords are also in part description.    HOLD
22    ERROR    Filename does not matches filetitle.    HOLD
23    ERROR    Author real name is not set.
24    ERROR    Author user name is not set.
25    ERROR    BFC is not set.    HOLD
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#56
(2018-01-30, 19:59)Willy Tschager Wrote: Next one:

21    ERROR    Some keywords are also in part description.    HOLD
22    ERROR    Filename does not matches filetitle.    HOLD
23    ERROR    Author real name is not set.
24    ERROR    Author user name is not set.
25    ERROR    BFC is not set.    HOLD

21 http://www.ldraw.org/article/340.html#keywords Strip the word appearing or number in the description from the keywords
22 Silly me! I cannot fine the related spec.
23 http://www.ldraw.org/article/398.html#Syntax Prompt
24 http://www.ldraw.org/article/398.html#Syntax Prompt
25 http://www.ldraw.org/article/415 Prompt
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#57
(2018-01-30, 19:59)Willy Tschager Wrote: Next one:

21    ERROR    Some keywords are also in part description.    HOLD
22    ERROR    Filename does not matches filetitle.    HOLD
23    ERROR    Author real name is not set.
24    ERROR    Author user name is not set.
25    ERROR    BFC is not set.    HOLD

21 Should not be holdable, change the spec
22 Reject submission to PT
23,24 These are required for licencing information, reject submission to PT
25 BFC required for all new parts, reject submission PT
Reply
RE: What requires a HOLD vote on the Parts Tracker
#62
25    ERROR    BFC is not set.    HOLD
26    ERROR    License is not set.    HOLD
27    ERROR    Part type is not set.    HOLD
28    ERROR    Primitives needs to have CCW winding.    HOLD
29    ERROR    Use of !KEYWORDS is not allowed for this part type.    HOLD
30    ERROR    Part description contains Tab character.    HOLD
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#63
(2018-02-06, 9:57)Willy Tschager Wrote: 25    ERROR    BFC is not set.    HOLD
26    ERROR    License is not set.    HOLD
27    ERROR    Part type is not set.    HOLD
28    ERROR    Primitives needs to have CCW winding.    HOLD
29    ERROR    Use of !KEYWORDS is not allowed for this part type.    HOLD
30    ERROR    Part description contains Tab character.    HOLD

25 http://www.ldraw.org/article/415 Prompt
26 http://www.ldraw.org/article/398.html Set automatically to !LICENSE Redistributable under CCAL version 2.0 : see CAreadme.txt
27 http://www.ldraw.org/article/398.html Prompt
28 http://www.ldraw.org/article/415.html#library Prompt
29 http://www.ldraw.org/article/340.html#scope Remove keywords
30 http://www.ldraw.org/article/218.html#files Prompt
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#64
Yes.
28- could be auto corrected: if primitive is CW, change type to CCW and invert winding of triangles and quads. Probably a moot point as most primitives are done with primgen, so no need to lose time on corrector...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#65
31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#66
(2018-02-20, 11:07)Willy Tschager Wrote: 31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.

31 http://www.ldraw.org/article/398.html#Syntax Prompt
32 ???
33 http://www.ldraw.org/article/398.html This is clearly wrong as (Needs work) is allowed.
34 ???
35 http://www.ldraw.org/article/340 Prompt for primitives

Mike! Please help.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#67
(2018-02-24, 8:54)Willy Tschager Wrote:
(2018-02-20, 11:07)Willy Tschager Wrote: 31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.

31 http://www.ldraw.org/article/398.html#Syntax Prompt
32 ???
33 http://www.ldraw.org/article/398.html This is clearly wrong as (Needs work) is allowed.
34 ???
35 http://www.ldraw.org/article/340 Prompt for primitives

Mike! Please help.

w.

I just answer right our of my mind:
31: - what do you mean with "Prompt"
32: These words are time based (now) and shall be not used - see several discussions in the old forum
33: clearly correct, as you have to describe what needs work in the comments
34: There is a problem with the !Category entry. - i need to file to see what causes this error.
35: - what do you mean with "Prompt" - primitives are not allowed to carry a !Category entry.

If I remember correctly this is all written in the documentation of DATHeader. Currently I do not have the time to look into it. Sorry.
cu
Mikeheide
- I made a wrong numbering, now fixed -
Reply
RE: What requires a HOLD vote on the Parts Tracker
#68
(2018-02-24, 11:13)Michael Heidemann Wrote:
(2018-02-24, 8:54)Willy Tschager Wrote: 31 http://www.ldraw.org/article/398.html#Syntax Prompt
32 ???
33 http://www.ldraw.org/article/398.html This is clearly wrong as (Needs work) is allowed.
34 ???
35 http://www.ldraw.org/article/340 Prompt for primitives

Mike! Please help.

w.

I just answer right our of my mind:
33: - what do you mean with "Prompt"
34: These words are time based (now) and shall be not used - see several discussions in the old forum
35: clearly correct, as you have to describe what needs work in the comments
36: There is a problem with the !Category entry. - i need to file to see what causes this error.
37: - what do you mean with "Prompt" - primitives are not allowed to carry a !Category entry.

If I remember correctly this is all written in the documentation of DATHeader. Currently I do not have the time to look into it. Sorry.
cu
Mikeheide

Based on Mike's feedback:

33: Not an error
34: Style based, not an error
35: Not an error
36: If it's for a !CATEGORY without an entry or a category that is not on the master list then hold
37: Hold for primitives and subparts
Reply
RE: What requires a HOLD vote on the Parts Tracker
#69
(2018-02-20, 11:07)Willy Tschager Wrote: 31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.

Now I have my code on hand and will give a more detailed information of the meaning of this short error messages.
31 - The entry in the !HELP section exceeds the length of 90 characters in a single line. The 90 characters are implemented after the 50 character limit seemed to the people too short.
32 - If we describe a parts shape as "new" it will be in maybe one year "old". So type1 or similar will work much better.
33 - (Needs work) is allowed _if_ there is a comment that explains what needs to be done. If there is no comment this error will rise.
34 - The !CATEGORY entry has to be from the list of categories that is available on LDraw.org. If this is not the case this error will rise.
35 - Part types are (Part|Subpart|Primitive|48_Primitive|Shortcut) and for some the use of !CATEGORY is not allowed. If used for the wrong part type this error will rise.

I hope this will help.
Mikeheide
Reply
RE: What requires a HOLD vote on the Parts Tracker
#70
(2017-12-08, 20:51)Willy Tschager Wrote: Officially we have only the outdated L3P error list:

http://www.ldraw.org/library/tracker/ref/l3pmsg/

while most of us use the output of Datheader (the following list was kindly provided by Mike Heidemann, author of the prog):


1    ERROR    Embedded POV Code found.    HOLD
2    ERROR    '0 WRITE' found. - HOLD
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD
4    ERROR    '0 ROTATION' found.    HOLD
5    ERROR    '0 COLOR' found.    HOLD
6    ERROR    Incorrect use of only '0' for comments. Should be '0 //' instead.
7    ERROR    Not all used colors in LDConfig.ldr.    HOLD
8    ERROR    Matrix all zero found.    HOLD
9    ERROR    Identical vertices found.    HOLD
10    ERROR    Colinear vertices found.    HOLD
11    ERROR    Bad Vertex Sequence found.    HOLD
12    ERROR    Concave quads found.    HOLD
13    ERROR    Coplanarity.    HOLD
14    ERROR    Incorrect color for linetype.    HOLD
15    ERROR    Loop in reference found.    HOLD
16    ERROR    Double lines found.    HOLD
17    WARNING    Maybe wrong color for sticker used.
18    ERROR    Length of part description.    HOLD
19    WARNING    Maybe leading spaces in part description.
20    ERROR    Keywords entry length.
21    ERROR    Some keywords are also in part description.    HOLD
22    ERROR    Filename does not matches filetitle.    HOLD
23    ERROR    Author real name is not set.
24    ERROR    Author user name is not set.
25    ERROR    BFC is not set.    HOLD
26    ERROR    License is not set.    HOLD
27    ERROR    Part type is not set.    HOLD
28    ERROR    Primitives needs to have CCW winding.    HOLD
29    ERROR    Use of !KEYWORDS is not allowed for this part type.    HOLD
30    ERROR    Part description contains Tab character.    HOLD
31    ERROR    HELP entry length.
32    ERROR    Word 'new' or 'old' is used in part description.
33    ERROR    Use of (Needs work).    HOLD
34    ERROR    Entry for !CATEGORY.
35    ERROR    Use of !CATEGORY is not allowed at for this part type.
36    ERROR    High-res primitive has to start with '48\'.    HOLD
37    ERROR    Description for primitives should not start with '_' or '~'.    HOLD
38    ERROR    Filename for parts, shortcuts and primitives should not start with '48\' or 's\'.    HOLD
39    ERROR    Filename for subparts has to start with 's\'.    HOLD
40    ERROR    Description for subparts has to start with '~'.    HOLD
41    ERROR    Description for subparts should not start with '_' or '='.
42    ERROR    Description for parts should not start with '_' or '='.
43    ERROR    Description for shortcuts and/or physical_colour parts has to start with '_'.    HOLD
44    ERROR    Filename for shortcuts contains usually a 'c' or 'd'.
45    ERROR    Extension has to be .dat    HOLD
46    ERROR    Special characters in description not allowed.    HOLD
47    ERROR    Lines do not end with <CR><LF>.
48    ERROR    Author !HISTORY entry has no brackets.
49    ERROR    Not scalable primitive is scaled.
50    ERROR    primitive is scaled not only in Y direction.
51    ERROR    First line after BFC INVERTNEXT isn't linetype 1.
52    ERROR    Problem with the RGB value.
53    ERROR    '~Moved to' file used.
54    ERROR    Wrong BFC command found.
55    ERROR    Some keywords are used twice in KEYWORDS section.    HOLD
56    ERROR    'Minifig Accessory' found in part description.
57    ERROR    'Figure Accessory' found in part description.
58    WARNING    'INVERTNEXT' used although not necessary.
59    WARNING    TJunktion detected.
60    ERROR    Wrong brackets around username used. Only [] is allowed
61    ERROR    Description for alias parts should start with '='
62    ERROR    Description for Physical_Colour parts should mention the used colors
63    ERROR    Only linetype 0 and 1 are allowed in Physical_Colour parts.
64    ERROR    Wrong color (16 or/and 24) used for Physical_Colour part
65    ERROR    Only linetype 0 and 1 are allowed in Alias parts.
66    ERROR    Only one (1) linetype 1 is allowed in Alias parts.
67    ERROR    Only color 16 is allowed in Alias parts.
68    ERROR    Alias needs to be mentioned in the comments in the form 'Alias of partnumber'.
69    ERROR    Mentioned part number in the alias comment is wrong.
70    WARNING    Origin is outside the Boundingbox.
71    ERROR    American English words used in part description.
72    WARNING    Too much empty lines at the end of the file.
73    WARNING    Mirrored studs detected.
74    WARNING    Flat subfile scaled in flat direction
75    ERROR    Optional line with same vertices than line found.
76    ERROR    Leading or trailing zeros found.
77    ERROR    Overlapping triangle found.
78    ERROR    Lines with wrong number of arguments found.
79    WARNING    Filename ending does not match declared LDRAW_ORG file type.
80    ERROR    Moved To setnumber with Extension    HOLD
81    WARNING    Filename ending does not match declared LDRAW_ORG part type qualifier.


w.
I just like to mention here that most of the errors that are marked with HOLD are confirmed with our PT Admin on 08.11.2009. The original request for adding this HOLD vote hint came from Willy Tschager.
But I am open for changes if they are useful.
cu
mikeheide
Reply
RE: What requires a HOLD vote on the Parts Tracker
#71
Mike,

just read above. We are using Datheader's error list to understand what an online version on the PT should looking for.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#4
I mostly agree that we are too strict overall... But another thing to factor in is the scarcity of reviewers. If I don't like something in a part I put a novote with comments, but there are so few reviewers, who could overwhelm my opinion, that a hold -  somehow forcing the author to react - would perhaps be better...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#78
(2017-12-09, 9:00)Philippe Hurbain Wrote: I mostly agree that we are too strict overall... But another thing to factor in is the scarcity of reviewers. If I don't like something in a part I put a novote with comments, but there are so few reviewers, who could overwhelm my opinion, that a hold -  somehow forcing the author to react - would perhaps be better...

...I totally agree with your opinion
Reply
RE: What requires a HOLD vote on the Parts Tracker
#6
I generally ask myself: is it necessary to fix the problem to release the part? If a wrong color is used, it will affect the end user a lot more than a missing contour. Concave quadrilaterals can cause misinterpretations by software so those, of course, must be fixed. A BFC error can cause potentially major rendering issues so those should always net a hold vote. A t-junction, that might cause some minor rendering artifacts and I try to avoid them in my work but I don't see why it should necessitate a hold vote. Or minor gaps or bleed-ins that generally are not visible unless you take a very close look at it.

I think that we often find problems (such as t-junctions) that would be nice to fix but shouldn't cause problems in by far most use cases. Currently these get a hold vote or, like Philo said, we keep back our certify votes for. The only current alternative is, right now, to put a "(Needs work)" qualifier which to me carries the connotation that the part requires major rework and we generally don't use it for simple problems.

We should keep in mind that generally people want these parts to build models with, and models have a scale much larger than what we as parts authors deal with. Our scale is 0.1 - 100 LDU or so in most cases; for models, 100 LDU is just the length of a 5 stud brick!

So perhaps we need better a platform for that? Maybe a list of issues (like a bug tracker of sorts) somewhere on the PT which would list parts that are released with issues, minor or major. Major issues are those that we currently apply the "(Needs work)" treatment to. Minor issues would then be ones that we can fix in a future update. Then we would have less issues to raise a hold vote for, or to keep back a certify for. Instead, release and put a note down that we should fix this later. This will probably create a backlog of things to deal with but that would still be better than a hundred parts held back for minor issues that aren't getting updates for years to come. Prioritize.

Perhaps there could also a third category for things that would be nice but what aren't realistic to deal with right away?

(nth) Edit: I also thought that a major part of the problem seems to be that when the part is released, it disappears from the parts tracker and needs to be re-submitted to it to be edited again, losing comment history in the process. So our only options are to release or keep it on the PT. I think that these shouldn't be mutually exclusive. A part with non-showstopper issues could be both released and kept on the PT for rework. A part with major issues can be released with a Needs Work modifier. Why does releasing a part remove it from the PT entirely anyway instead of just archiving it?
Reply
RE: What requires a HOLD vote on the Parts Tracker
#22
(2017-12-09, 14:31)Santeri Piippo Wrote: I also thought that a major part of the problem seems to be that when the part is released, it disappears from the parts tracker and needs to be re-submitted to it to be edited again, losing comment history in the process. So our only options are to release or keep it on the PT. I think that these shouldn't be mutually exclusive. A part with non-showstopper issues could be both released and kept on the PT for rework. A part with major issues can be released with a Needs Work modifier. Why does releasing a part remove it from the PT entirely anyway instead of just archiving it?

This would be a substantial change to the (already complex) way the update build process works, but that is not to say it is impossible. The review history is archived - there just isn't a web interface to display it.
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#7
I don't think we should lower our standards only to get more parts released.
Making a list of parts with known issues is just a waste of time and effort. No one will ever rework that list of parts. Look at the list of parts with known BFC errors on the PT. No one was working it, untill I decided to do that.

What we need are more active rewiers and more responsive part authors. Uploading a part and not responding on a review is a waste of the reviewers time and effort. 
If I give a review in a Novote and the author ignores my opinion, I'm not likely going to review his next part. A second reviewer will ignore the file. Someone else has already revied it, and found some errors in it. Giving a Hold-vote is the only way to move things forward. I'm only allowed to change a bad file that have a Hold vote.

I also don't like the trend we are currently seeing. A sprint of hasty reviews only to get parts into the next release. Making parts take time, and reviewing them also takes time, and isn't something that should be done in the last minute. I prefer a more constant stream of releases, giving us a chance to quickly correct any faulty parts that needs recycling.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#21
(2017-12-09, 15:43)Magnus Forsberg Wrote: I also don't like the trend we are currently seeing. A sprint of hasty reviews only to get parts into the next release. Making parts take time, and reviewing them also takes time, and isn't something that should be done in the last minute. I prefer a more constant stream of releases, giving us a chance to quickly correct any faulty parts that needs recycling.

More frequent releases is definitiely the way forward. I'd like to move to at least a three-monthly schedule, as I should have more time next year (and I'm working hard to get an update out before the end of 2017).
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#9
I'm not concerned about the errors that can be fixed with a set of rules but when HOLDs are given based on "believe":

* I believe .... this is a subpart, part, shortcut, color xxx, ...

I think the final decision on part numbering, description and file type should be entirely up to the PT admin. Part authors might give suggestions but not HOLD them - 'cos with the system in place a HOLD cannot be overruled, not even with 10 CERTIFIED and an admin CERTIFIED. A HOLD has all the power a CERTIFIED has none.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#10
To proceed I suggest a hand down approach with revising Mike Heide's list as a starting point for Santeri Piippo if he is willing to code this up.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#11
(2017-12-10, 9:27)Willy Tschager Wrote: To proceed I suggest a hand down approach with revising Mike Heide's list as a starting point for Santeri Piippo if he is willing to code this up.

w.

A web based part checker? Sure, I could use such a thing too since I also use Linux.

I'll get started on the groundwork.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#20
(2017-12-10, 11:42)Santeri Piippo Wrote:
(2017-12-10, 9:27)Willy Tschager Wrote: To proceed I suggest a hand down approach with revising Mike Heide's list as a starting point for Santeri Piippo if he is willing to code this up.

w.

A web based part checker? Sure, I could use such a thing too since I also use Linux.

I'll get started on the groundwork.

Please don't start something independent. The best way to do this is to integrate it into the Parts Tracker. Please PM me and we can discuss.
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#12
Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#13
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

For sure 2, 3 and 4 (and actually I think all 5) could and should be autocorrected by the validator. Actually that's what DH does...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#14
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

All five should result in a hold vote. They can be fixed by the validator but there is the need of a visual check of the part and code by the parts author.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#15
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

1, 2 and 4 : Autocorrect, delete the code, it is not requird in a part. WRITE may contain a comment, so maybe remove WRITE and reformat to a proper comment

3: Autocorrect, change to the proper command

5: Not sure, may be used in prints or stickers?

Edit: May be we shall use a Google doc sheet or something everybody can edit in the browser to collect the views.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#16
(2017-12-12, 8:12)Gerald Lasser Wrote: Edit: May be we shall use a Google doc sheet or something everybody can edit in the browser to collect the views.

Agreed. This is going to get real confusing if we do this in a forum thread.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#18
(2017-12-12, 9:31)Santeri Piippo Wrote:
(2017-12-12, 8:12)Gerald Lasser Wrote: Edit: May be we shall use a Google doc sheet or something everybody can edit in the browser to collect the views.

Agreed. This is going to get real confusing if we do this in a forum thread.

I did the frame work for it, let me know if you can access & edit
https://docs.google.com/spreadsheets/d/1...sp=sharing
Reply
RE: What requires a HOLD vote on the Parts Tracker
#23
(2017-12-12, 22:33)Gerald Lasser Wrote:
(2017-12-12, 9:31)Santeri Piippo Wrote: Agreed. This is going to get real confusing if we do this in a forum thread.

I did the frame work for it, let me know if you can access & edit
https://docs.google.com/spreadsheets/d/1...sp=sharing

Gerald, so you're going to do all the paperwork :-) Fine with it.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#25
I started to fill in the doc, but some of my comments blow out cell size. What should be the proper way?
Reply
RE: What requires a HOLD vote on the Parts Tracker
#26
(2017-12-14, 13:11)Philippe Hurbain Wrote: I started to fill in the doc, but some of my comments blow out cell size. What should be the proper way?
Linewrap is making it look fine again.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#27
OK... for some reason it didn't wrap for me, even after a reload. Works fine now.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#49
(2017-12-12, 22:33)Gerald Lasser Wrote:
(2017-12-12, 9:31)Santeri Piippo Wrote: Agreed. This is going to get real confusing if we do this in a forum thread.

I did the frame work for it, let me know if you can access & edit
https://docs.google.com/spreadsheets/d/1...sp=sharing

Thinking about this in the context of the part verifier: how does "prompt" go over? The part verifier says that "sorry but there's this and this issue in the part, do you want me to try to fix these"?

And regarding potential PT integration: should the PT try to prompt anything or just reject the part if such problems exist and call it a day? It needs rework anyway at that point so IMO it can't be ready for PT in that case.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#50
(2018-01-06, 20:35)Santeri Piippo Wrote:
(2017-12-12, 22:33)Gerald Lasser Wrote: I did the frame work for it, let me know if you can access & edit
https://docs.google.com/spreadsheets/d/1...sp=sharing

Thinking about this in the context of the part verifier: how does "prompt" go over? The part verifier says that "sorry but there's this and this issue in the part, do you want me to try to fix these"?

And regarding potential PT integration: should the PT try to prompt anything or just reject the part if such problems exist and call it a day? It needs rework anyway at that point so IMO it can't be ready for PT in that case.

Well. I'd say it the verifier is able to fix it the part should be fixed. Otherwise it would just reject by telling what has triggered the error. Period.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#54
Quote:And regarding potential PT integration: should the PT try to prompt anything or just reject the part if such problems exist and call it a day? It needs rework anyway at that point so IMO it can't be ready for PT in that case.
Just to make sure: any certification tool must report ALL the issues it finds and can't auto-correct, and not stop after finding the first error...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#24
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

1 Remove
2 Convert
3 Convert
4 Remove
5 Remove

All should trigger a HOLD
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#28
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

If there isn't any new input I move forward to the next block.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#29
(2017-12-16, 11:05)Willy Tschager Wrote:
(2017-12-11, 18:23)Willy Tschager Wrote: Since there a almost 80 position I suggest to work on them in a block of five. So the question is should these trigger a HOLD vote or just a WARNING (comment)?

1    ERROR    Embedded POV Code found.    HOLD 
2    ERROR    '0 WRITE' found. - HOLD 
3    ERROR    '0 BFC CERTIFY INVERTNEXT' found.    HOLD 
4    ERROR    '0 ROTATION' found.    HOLD 
5    ERROR    '0 COLOR' found.    HOLD

I further suggest that if a part gets certified with non resolved warnings those should be documented by a simple comment in the part itself.

w.

If there isn't any new input I move forward to the next block.

w.

I'll comment in the document in a few days when I finished working for this year. ;-)
Please feel free to move forward, cause my thoughts to the first 5 points are very similiar to Philo's.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#17
Hello and good evening

I read this topic with great enthusiasm, and would like to comment on it.
Although I am still a young partauthor, but I also think that quality should be more important than quantity.
Although I was annoyed at the beginning, when I received the first "HOLD" for a simple sticker.
In retrospect, I was able to understand the holds very well. It was only minor things, but it was just mistakes.
I just think it's a pity people do not fix the mistakes when they get a hold.
Certainly, a lot of work and time is required to check the parts very carefully, but at the end of the day it's just 99.99% perfect parts.
If there is a routine for checking the parts in the PT, this is also beneficial to the parts author. Thus, he immediately sees the big mistakes and can repair them even before the first upload.
Has the advantage that less defective parts are uploaded to the PT and parts do not have to be checked by the reviewers as often.
Saves resources and thus raises the quality and quantity.

Regards Johann
If nothing goes right, go left.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#19
Just to give my point of view: as long as the reviewer and the author can discussed about a controvertial « hold » vote, I see no reason not to be strict.

As for me, anything related to part structure, anthoring rules or anything clearly defined in the standards should be holded, and the author must correct it.
Then, when it comes to pattern, complex surfaces geometry or anything that can get different interpretation, a hold vote should be clearly justified and the reviewer should be openned to discussed it, taking into account the author’s aguments. As for me, the tracker is already working that way.



Talking about my part’s reviews: I can’t complain because I try to correct holded parts asap and I never felt « hold abuse » from the reviewers (who I thank a lot btw).

Less « hold » is not what we need to get certified parts faster. What we need is an army of reviewer/authors to get the tracker to zero pending parts. If I would be an active reviewer, I would be kinda feared of this huge amount of parts waiting to be certified, and I wouldn’t know where to start. Cleaning the tracker would be a good start I guess, but that’s not an easy job.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#58
I have now gotten a proof-of-concept part checker up:

Tests currently implemented:
  • Check for self-intersecting, skew and concave quads
  • Check for collinearity
  • Check for zero matrix determinant (row or column all zero)
  • Check for scaling of not-scalable primitives (needs some kind of threshold)
  • Check for invalid colours (not in LDConfig.ldr and not direct colours, restrictions on direct colours not yet implemented)

The quadrilateral checks can create redundant errors, e.g. a report for concave quad when it's actually a bowtie, because technically bowtie quads are concave and there's separate tests making these results.

No header tests yet because the header currently is not parsed at all. No corrections performed yet either.

Also includes a test for very thin polygons (smallest angle less than 0.5°). While they are not considered a problem, they're reported as a purely informational notice since they can point to other problems (e.g. gaps).
Reply
RE: What requires a HOLD vote on the Parts Tracker
#59
(2018-01-31, 13:18)Santeri Piippo Wrote: I have now gotten a proof-of-concept part checker up:

Tests currently implemented:
  • Check for self-intersecting, skew and concave quads
  • Check for collinearity
  • Check for zero matrix determinant (row or column all zero)
  • Check for scaling of not-scalable primitives (needs some kind of threshold)
  • Check for invalid colours (not in LDConfig.ldr and not direct colours, restrictions on direct colours not yet implemented)

The quadrilateral checks can create redundant errors, e.g. a report for concave quad when it's actually a bowtie, because technically bowtie quads are concave and there's separate tests making these results.

No header tests yet because the header currently is not parsed at all. No corrections performed yet either.

Also includes a test for very thin polygons (smallest angle less than 0.5°). While they are not considered a problem, they're reported as a purely informational notice since they can point to other problems (e.g. gaps).

Pllease don't spend time on adding header checks. I have a header checking script that I use during the Parts Update build and this will soon be incoporated into the submit process. I'll also review this thread to see if other header checks need to be added.
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#60
(2018-01-31, 13:18)Santeri Piippo Wrote: I have now gotten a proof-of-concept part checker upTongueretty nice so far! and damn fast Wink
One little request, even during debugging phase: please display the name of file just processed, it allows find again the file tested to check results againt other tools (easy to get lost in my huge collection of old files!)

I noticed that angles for coplanarity checks are consistently a bit lower than values reported by LDDP or planarcheck. Not annoying here, but might hide a more serious problem?


Quote:Also includes a test for very thin polygons (smallest angle less than 0.5°). While they are not considered a problem, they're reported as a purely informational notice since they can point to other problems (e.g. gaps).
Min/max colinear theresholds are specified here: http://www.ldraw.org/article/512.html#colinear. Might be interesting to display a warning for lower/higher values...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#61
(2018-01-31, 14:18)Chris Dee Wrote: Pllease don't spend time on adding header checks. I have a header checking script that I use during the Parts Update build and this will soon be incoporated into the submit process. I'll also review this thread to see if other header checks need to be added.
Interesting. I guess I'll dedicate to the body checks then.

(2018-01-31, 14:41)Philippe Hurbain Wrote: Pretty nice so far! and damn fast Wink
Thanks!

Quote:One little request, even during debugging phase: please display the name of file just processed, it allows find again the file tested to check results againt other tools (easy to get lost in my huge collection of old files!)
The commandline tool does that but for the web front I didn't think it was so important yet. But you make a point and I'll add it.

Quote:I noticed that angles for coplanarity checks are consistently a bit lower than values reported by LDDP or planarcheck. Not annoying here, but might hide a more serious problem?
Coplanarity is checked by splitting the quad and computing the skew angle from the angle between the two plane normals. Both triangle configurations are tested and the first one to yield a problem is reported. Come to think of it, it needs to test both and use the larger angle.

Quote:Min/max colinear theresholds are specified here: http://www.ldraw.org/article/512.html#colinear. Might be interesting to display a warning for lower/higher values...
I think I need to rewrite the concave and colinear tests so that I can use these angle thresholds. Right now I'm using vector math.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#72
While in Billund we worked on Datheader's HOLD list an came up with this:


.pdf   LDraw HOLD Reasons.pdf (Size: 32.25 KB / Downloads: 24)

The process was working through the list and compare it with the current specs as well as how things are currently handled on the PT. As you can see there is just one point left for discussion.

The rest of Orion list:


Quote:Things that should generate a warning but not a HOLD:
- Small gaps
- Wrong KEYWORDS or CATEGORY
- Semantics issues like, this should be a subpart
- Anything that the PT Admin can fix (e.g. Header issues)
- Minor color problems
- Basically anything that can be fixed after initial release without breaking models that use the part.

is more a "political" thing. How do we handle the parts with the above errors that clearly need a (Needs work) in the description, when the original author has lost interest in the part. If it is on HOLD for more than three months, otherwise you would have to ping the PT admin to add the note to the description. I do not think that a simple comment addresses the above problems properly. Would there be a chance to add a WARNING to the PT that stands somehow between HOLD and Comment?

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#73
(2019-05-27, 10:29)Willy Tschager Wrote: While in Billund we worked on Datheader's HOLD list an came up with this:



The process was working through the list and compare it with the current specs as well as how things are currently handled on the PT. As you can see there is just one point left for discussion.

The rest of Orion list:



is more a "political" thing. How do we handle the parts with the above errors that clearly need a (Needs work) in the description, when the original author has lost interest in the part. If it is on HOLD for more than three months, otherwise you would have to ping the PT admin to add the note to the description. I do not think that a simple comment addresses the above problems properly. Would there be a chance to add a WARNING to the PT that stands somehow between HOLD and Comment?

w.

How do you envisage a WARNING vote affecting the certification status? To override the reviewers existing CERT vote, like a Comment, or should it add another vote letter that nees to be cleared before the part can be released? The latter would be complex to implement but could potentially be rolled into a much-needed Parts Tracker redevelopment.

Alternatively, and much simpler to implement, could it work like a comment but automatically email the PT admin for atttention. In which case merely adding a 'Send comment to admin' checkbox to the review page would be even easier to implement and of more general applicability as it could be used on other vote types (e.g. HOLD votes to request deletions, CERT votes to warn of dependencies).
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#74
(2019-05-27, 11:04)Chris Dee Wrote: How do you envisage a WARNING vote affecting the certification status? To override the reviewers existing CERT vote, like a Comment, or should it add another vote letter that nees to be cleared before the part can be released? The latter would be complex to implement but could potentially be rolled into a much-needed Parts Tracker redevelopment.

Alternatively, and much simpler to implement, could it work like a comment but automatically email the PT admin for atttention. In which case merely adding a 'Send comment to admin' checkbox to the review page   would be even easier to implement and of more general applicability as it could be used on other vote types (e.g. HOLD votes to request deletions, CERT votes to warn of dependencies).

I see WARNING as a comment on a HOLD, CERTIFY, or NOVOTE. These aren't necessarily errors but may be poor style, minor improvements that don't really need to be fixed, or stuff that the admin can fix.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#75
(2019-05-27, 11:04)Chris Dee Wrote: How do you envisage a WARNING vote affecting the certification status? To override the reviewers existing CERT vote, like a Comment, or should it add another vote letter that nees to be cleared before the part can be released? The latter would be complex to implement but could potentially be rolled into a much-needed Parts Tracker redevelopment.

Alternatively, and much simpler to implement, could it work like a comment but automatically email the PT admin for atttention. In which case merely adding a 'Send comment to admin' checkbox to the review page   would be even easier to implement and of more general applicability as it could be used on other vote types (e.g. HOLD votes to request deletions, CERT votes to warn of dependencies).

I envision this a stronger comment. You could certify a part with minor flaws and add a WARNING in addition to make the PT admin aware that it might needs a (Needs Work) in description and comment if it hasn't already been added by the author just willing to add the (Needs Work) without fixing the error.

Looking at the parts you can find many with very minor flaws where the reviewer preferred comment on, but not certify. The WARNING should clear this hesitation.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#76
(2019-05-27, 18:26)Willy Tschager Wrote: Looking at the parts you can find many with very minor flaws where the reviewer preferred comment on, but not certify.
Yes, considering the scarcity of reviewers, this kind of novote is actually close to a hold...
Reply
RE: What requires a HOLD vote on the Parts Tracker
#79
(2019-05-27, 10:29)Willy Tschager Wrote: While in Billund we worked on Datheader's HOLD list an came up with this:



The process was working through the list and compare it with the current specs as well as how things are currently handled on the PT. As you can see there is just one point left for discussion.

The rest of Orion list:



is more a "political" thing. How do we handle the parts with the above errors that clearly need a (Needs work) in the description, when the original author has lost interest in the part. If it is on HOLD for more than three months, otherwise you would have to ping the PT admin to add the note to the description. I do not think that a simple comment addresses the above problems properly. Would there be a chance to add a WARNING to the PT that stands somehow between HOLD and Comment?

w.
I do not fully understand this pdf file.
All the lines mention one error and/or warning that DatHeader will give to the user based on the specs. we made.
These errors/warnings are not related to the hold vote on the PT.
For some errors I was asked to mention that it shall be a hold vote. So I added in the error message the word "HOLD".
I will now remove the word "HOLD" on the lines where not a yellow HOLD is mentioned and add the word if in the file is a yellow HOLD.
I use the word "WARNING" instead of "ERROR" if DatHeader is unable to decide if the item is in this contect correct or not. The user has to decide it.
Sadly I have no idea what you have in mind if you write "Remove" in the pdf file. Shall I remove the check for this error?

cu
mikeheide
Reply
RE: What requires a HOLD vote on the Parts Tracker
#81
(2019-06-08, 21:16)Michael Heidemann Wrote: For some errors I was asked to mention that it shall be a hold vote. So I added in the error message the word "HOLD".

And that is fine.

(2019-06-08, 21:16)Michael Heidemann Wrote: I will now remove the word "HOLD" on the lines where not a yellow HOLD is mentioned and add the word if in the file is a yellow HOLD.

Fine also with that.

(2019-06-08, 21:16)Michael Heidemann Wrote: I use the word "WARNING" instead of "ERROR" if DatHeader is unable to decide if the item is in this contect correct or not. The user has to decide it.

Yep.

(2019-06-08, 21:16)Michael Heidemann Wrote: Sadly I have no idea what you have in mind if you write "Remove" in the pdf file. Shall I remove the check for this error?

That was the idea. Take for example "Maybe wrong color for sticker used." A reviewer has to spot if the colors are right or wrong. If the aren't in the LDConfig it should be a direct color and it is up to the reviewer/author to decide if it was the right pick. Same for "Length of part description" since we completely dropped any length limits.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#85
(2019-06-09, 7:59)Willy Tschager Wrote: And that is fine.


Fine also with that.


Yep.


That was the idea. Take for example "Maybe wrong color for sticker used." A reviewer has to spot if the colors are right or wrong. If the aren't in the LDConfig it should be a direct color and it is up to the reviewer/author to decide if it was the right pick. Same for "Length of part description" since we completely dropped any length limits.

w.
Ok, now I understand your idea when the reason of the checks are gone, no check is needed.

cu
mikeheide
Reply
RE: What requires a HOLD vote on the Parts Tracker
#86
(2019-05-27, 10:29)Willy Tschager Wrote: While in Billund we worked on Datheader's HOLD list an came up with this:



The process was working through the list and compare it with the current specs as well as how things are currently handled on the PT. As you can see there is just one point left for discussion.

The rest of Orion list:



is more a "political" thing. How do we handle the parts with the above errors that clearly need a (Needs work) in the description, when the original author has lost interest in the part. If it is on HOLD for more than three months, otherwise you would have to ping the PT admin to add the note to the description. I do not think that a simple comment addresses the above problems properly. Would there be a chance to add a WARNING to the PT that stands somehow between HOLD and Comment?

w.

I'd like to update this page:
https://www.ldraw.org/library/tracker/ref/l3pmsg/

With the above guidelines.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#87
(2019-06-16, 3:11)Orion Pobursky Wrote: I'd like to update this page:
https://www.ldraw.org/library/tracker/ref/l3pmsg/

With the above guidelines.

Go ahead. Could the non-BFC column be removed, as we expect everything tpo be BFC these days?
Chris (LDraw Parts Library Admin)
Reply
RE: What requires a HOLD vote on the Parts Tracker
#88
yes please.

we have brought the BFC-problematic files to nearly 0 now.

just a small handful of "weird relicts" are remaining:
https://www.ldraw.org/cgi-bin/ptbfcstatus.cgi

I suggest to delete all of them from the PT:
- one is a "minifig torso + head" physical shortcut assembly which - if we would add these combinations to the library - would make the library size explode due to the possible combination
- the others are mockups which have no visual resemblence with the parts they mimick and are waiting unfinished for years now on the PT.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#90
(2019-05-27, 10:29)Willy Tschager Wrote: While in Billund we worked on Datheader's HOLD list an came up with this:



The process was working through the list and compare it with the current specs as well as how things are currently handled on the PT. As you can see there is just one point left for discussion.

The rest of Orion list:



is more a "political" thing. How do we handle the parts with the above errors that clearly need a (Needs work) in the description, when the original author has lost interest in the part. If it is on HOLD for more than three months, otherwise you would have to ping the PT admin to add the note to the description. I do not think that a simple comment addresses the above problems properly. Would there be a chance to add a WARNING to the PT that stands somehow between HOLD and Comment?

w.
At least I just uploaded the new version (3.0.23.0) of DATHeader for covering the changes for hold and warnings.

In case you will find still errors, please just send me a PM by email, because I not very often in the forum these days.

cu
Mikeheide
Reply
RE: What requires a HOLD vote on the Parts Tracker
#91
(2019-11-06, 19:47)Michael Heidemann Wrote: At least I just uploaded the new version (3.0.23.0) of DATHeader for covering the changes for hold and warnings.
Thanks Mike!
Reply
RE: What requires a HOLD vote on the Parts Tracker
#77
.... for my part ... I look at the whole thing more like Magnus ..

... his "Swedish Hammer" ... met me here in my beginnings more often than I liked ... funny meant ...
but that was also a good intensive school ..

... it may be that this scares off many younger aspirants ... but those who develop beyond that ... will become good authors too ...

And yes ... a review needs a lot of time..to create parts, however, even more time ... accordingly.

"Quality over Quantity" ... also shapes the mindset of new generation generations of "LDrawer's" ... wants to be called ... and thus also the future of LDraw.

and right there ... we should ... set the lever ...

... well made and as simple as imaginable made tutorials ... summarized like a textbook ..... best still imaged .. and integrated links .... as a loadable PDF file ....

.... well and manageable structured .. and updated and supplemented again and again ..... to make it easier for the beginners.

The international popularity of Ldraw ... could be underlined by translations of these Tuitorials in various languages ...
..that would of course be a dynamic group work announced.

Willi has already done a lot in this respect on his homepage.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#80
(2019-05-28, 12:48)Ulrich Röder Wrote: .... for my part ... I look at the whole thing more like Magnus ..

... his "Swedish Hammer" ... met me here in my beginnings more often than I liked ... funny meant ...
but that was also a good intensive school ..

... it may be that this scares off many younger aspirants ... but those who develop beyond that ... will become good authors too ...

And yes ... a review needs a lot of time..to create parts, however, even more time ... accordingly.

"Quality over Quantity" ... also shapes the mindset of new generation generations of "LDrawer's" ... wants to be called ... and thus also the future of LDraw.

and right there ... we should ... set the lever ...

... well made and as simple as imaginable made tutorials ... summarized like a textbook ..... best still imaged .. and integrated links .... as a loadable PDF file ....

.... well and manageable structured .. and updated and supplemented again and again ..... to make it easier for the beginners.

The international popularity of Ldraw ... could be underlined by translations of these Tuitorials in various languages ...
..that would of course be a dynamic group work announced.

Willi has already done a lot in this respect on his homepage.

From my perspective point of view as newbie.


When you submit your first parts, it's intimidating the amount of observations that you get and things you need to correct, with out anything pointing out how to fix the issue. Its demoralising and you need to have lot of force to keep on trying to fix your file.


May be doing a faq with the typical (most often) errors and how to fix them will help to newbies like me.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#82
(2019-06-08, 23:13)Victor Di Rienzo Wrote: Its demoralising and you need to have lot of force to keep on trying to fix your file.

As a reviewer and teacher I give critic, not to put you down. I want you to think, figure out what's wrong, and understand why. If you need more info to figure it out, just ask. And I want you to do that. It's my input, to becoming a better reviewer. 

(2019-06-08, 23:13)Victor Di Rienzo Wrote: May be doing a faq with the typical (most often) errors and how to fix them will help to newbies like me.

I agree, we should be better on documenting common errors, and hinting on how to fix them.
Reply
RE: What requires a HOLD vote on the Parts Tracker
#83
(2019-06-08, 23:13)Victor Di Rienzo Wrote: May be doing a faq with the typical (most often) errors and how to fix them will help to newbies like me.

Great idea! Go ahead with your questions and let us know what got you frustrated the most.

w.
LEGO ergo sum
Reply
RE: What requires a HOLD vote on the Parts Tracker
#84
(2019-06-09, 15:32)Willy Tschager Wrote: Great idea! Go ahead with your questions and let us know what got you frustrated the most.

w.

I think i have finally learn how to make the patterns and fulfill all the needs that are requested.

For me as there its a lot to read and to learn, the learning slope it is hi to get more people envolved . May be with video tutorials explaining all the proceess and adding them to a short guide to read may help too.

Also im thinking about cultural differences due most of people here are not native english speakes so reading and comprehension its more complex that a video to start the proccess, then if you are still interested all the documents available will make you undestand the underlying.
Reply
« Next Oldest | Next Newest »



Forum Jump:


Users browsing this thread: 1 Guest(s)