(2021-10-14, 2:26)Franklin W. Cain Wrote: So, I just add these lines into the file (using a more appropriate color code), correct?
Thanks, again! ;-)
Franklin
Hi Franklin,
Sorry, I totally missed your questions in the forum regarding my review.
As most of your questions seems to be solved just a short (or longer) note to this one.
First of all an explanation how I do reviews (the other reviewers might do it a bit different...):
a) open the File with LDDP and get a quick overview, read the header, check the description, the number etcs.
b) searching for real pictures (or grab in my own collection).
c) visual check in LDView (main color, random colour mode, bfc mode), first check for missing edges.
d) run the part through DatHeader and check the errors and warnings in LDView.
e) run the part through Edger2 - (with debug colours, to get unmatched edges, missing edges and missing condlines) Sidenote: unmatched edges is either the open end of a subpart, a gap or a t-junction.
f) open the file generated by Edger2 in LDView and make a visual check, verifiy the added edges and condlines and compare it with the original file in LDView visually.
g) if neccessary open one of both files or both files in LDPE and check the condlines and vertices there.
h) (sometimes I check the complete part in LDPE again (as LDPE has a nixe functions to show the errors and warnings in directly in the workspace))
i) write my review
For finding the gap, you need to add the edges to the file, to see where it is. Then fix the gap (correct corresponding lines and condlines, if neccessary) and delete the inserted lines.
If you have further question feel free to ask. :-)
And thank you very much for fixing the space in front of the codelines.
Best regards
/Max