Official Part Fix Submission


Official Part Fix Submission
#1
I'm considering allowing all registered authors to submit fixes to official parts. I have a feeling this has been admin only since the old PT code made submission and deletion a pain. Any strong opinions?
Reply
RE: Official Part Fix Submission
#2
I'm all for it, it lets us get things into the review process faster and certainly saves you some busywork.
Reply
RE: Official Part Fix Submission
#3
The only downside I can see is an increased workload on the reviewers. The growth of parts in need for a review is increasing.
We need to attract more reviewers.
Reply
RE: Official Part Fix Submission
#4
(2024-03-17, 7:37)Magnus Forsberg Wrote: The only downside I can see is an increased workload on the reviewers. The growth of parts in need for a review is increasing.
We need to attract more reviewers.

Well, these parts are already subject to the review process—or do you mean it will encourage more authors to submit official part fixes?
Reply
RE: Official Part Fix Submission
#5
Barring any hitches in testing, this change will go live tonight (PDT or Seattle time).
Reply
RE: Official Part Fix Submission
#6
good thing.

the review process anyway will catch problems,
and I really never understood why fixes to official files could not be uploaded easily
but instead required e-mailing to PT admin.

👍👍👍
Reply
RE: Official Part Fix Submission
#7
I found some other things that need to be addressed so this update will be pushed to later in the week.
Reply
RE: Official Part Fix Submission
#8
(2024-03-27, 4:35)Orion Pobursky Wrote: I found some other things that need to be addressed so this update will be pushed to later in the week.

I sent to [email protected] some update for official parts (example  "Update for patterned 2431 tiles" 24 april), I want to know if you received it. If not, it possibly an argue to update the process.
Reply
RE: Official Part Fix Submission
#9
You should now be able to submit these yourself.
Reply
RE: Official Part Fix Submission
#10
Currently the PT submit page still displays:

"To submit a fix for an existing file, email the file to [email protected], and it will be manually posted to the tracker."

Anyways, what should I take care for, when uploading an Official Part Fix?

I planned to do the patterns for part 6214 (https://library.ldraw.org/official/11212), which currently is a single file only. Comparing to similar parts, the main geometry usually gets put in a sub-file (missing the front face) and the pattern or plain front gets defined in the main file.
Whilst changing it to a subfiled structure test-wise, I also found 2 odd edge lines, which probably can be avoided.
Oh, and whilst I am at it, I could also add the missing inner tube supports this part has (6213 has them modelled in). Thoughts?

Assuming I would upload a new version of this part, a few questions arise:

1) Parts Author: Who becomes the author of the new subpart (it's like 80-90% data copied from the original file)?
2) History: Shall I leave this untouched or shall I describe my edits here? Does the sub-part get History lines upon first upload (copied from base part) or will these be empty?
3) In the Submit Form, shall the "Replace existing file(s)" be checked or not?
Reply
RE: Official Part Fix Submission
#11
(9 hours ago)Chris Böhnke Wrote: 1) Parts Author: Who becomes the author of the new subpart (it's like 80-90% data copied from the original file)?
2) History: Shall I leave this untouched or shall I describe my edits here? Does the sub-part get History lines upon first upload (copied from base part) or will these be empty?
3) In the Submit Form, shall the "Replace existing file(s)" be checked or not?
The subpart is a new file, so you take ownership, this file should have a blank history, except a notice like "subfiled from Tore Erikson 6214"
You also have to send admin an updated 6214, using the subfile you created, and an history line like "subparted for patterns"
The new subpart is... new so no need to check replace. The submit for replaced main part will be done by admin.
Reply
« Next Oldest | Next Newest »



Forum Jump:


Users browsing this thread: 1 Guest(s)