(2019-06-15, 11:04)Magnus Forsberg Wrote: All of them. Ldraw.org and the mock-ups are all treated as being "small monitors" on my 17" laptop.
I disagree.
I have to either swap to another browser, or buy a bigger screen/laptop if I want to use Firefox.
The break points are adjustable. How small is the Firefox viewport on your laptop?
(2019-06-15, 13:13)Orion Pobursky Wrote: I lowered the breakpoint by 100px. Is that better?
Yes, that's it. It instantly looked so much better.
But it seems to be right on the limit. If I change the width of the window, or the sidepanel, it flips to the more narrow layout.
(2019-06-15, 14:45)Magnus Forsberg Wrote: Yes, that's it. It instantly looked so much better.
But it seems to be right on the limit. If I change the width of the window, or the sidepanel, it flips to the more narrow layout.
2 suggestions:
- can we get rid of the "File Header:" heading? I think it is just wasting vertical space.
- can we lower the image so that its top border aligns with the top border of the first line of the file header?
(2019-06-17, 20:37)Damien Roux Wrote: I think I'm a bit late, but would it be complicated to add an option to choose to display part picture on the Parts List and on the Activity pages?
But actually, I must say I love this new layout, great job!
This would require new code. This project focused on changing the markup.
(2019-06-17, 19:33)Orion Pobursky Wrote: We are now live. The only glaring error I can find is history which I’ll look at fixing tonight.
Orion,
Concerning the alignment of the parts, I think this was everything on the top (Pic top below the cert-status) thus the pics were in one line. Have a look at the Minifig Heads
Can you make them in a line again?
(2019-06-17, 19:48)Orion Pobursky Wrote: Activity and ptlist also break formatting on mobile (but are fine on large screens) . I’ll fix that tonight as well.
Activity on mobile is fixed. Turns out it was a mobile Safari quirk.
(2019-06-17, 19:48)Orion Pobursky Wrote: Activity and ptlist also break formatting on mobile (but are fine on large screens) . I’ll fix that tonight as well.
part list is now fixed. Pattern summary update coming soon.
2019-06-18, 20:01 (This post was last modified: 2019-06-18, 20:02 by Steffen.)
I also like the new look a lot.
I have some minor improvement suggestions, but they can wait.
Here is one that I would like to ask right now:
can we modify the text that is displayed for a part as heading
- for the required files
- for its parent files?
Currently, the PT displays the texts
- "Required (unofficial) subfiles:" and
- "Related (unofficial) subfiles:"
, and both do not make sense. I would like to see that changed to:
- "Required Files:"
- "Parent Files:"
The reasoning is this:
1. nowadays, not all required files are "subparts" anymore. For example, for aliases, the required file is a normal part. See 55707c as example. So the wording "subfiles" for the required files is wrong IMHO.
2. the addition "(unofficial)" is completely unnecessary, because only such files are displayed. Official ones are not shown on the PT as dependency. The word only adds clutter.
3. for parent files, the wording "subfiles" makes no sense at all, it never did. We all just got used to the ever same text on the PT pages.
(2019-06-18, 20:01)Steffen Wrote: I also like the new look a lot.
I have some minor improvement suggestions, but they can wait.
Here is one that I would like to ask right now:
can we modify the text that is displayed for a part as heading
- for the required files
- for its parent files?
Currently, the PT displays the texts
- "Required (unofficial) subfiles:" and
- "Related (unofficial) subfiles:"
, and both do not make sense. I would like to see that changed to:
- "Required Files:"
- "Parent Files:"
The reasoning is this:
1. nowadays, not all required files are "subparts" anymore. For example, for aliases, the required file is a normal part. See 55707c as example. So the wording "subfiles" for the required files is wrong IMHO.
2. the addition "(unofficial)" is completely unnecessary, because only such files are displayed. Official ones are not shown on the PT as dependency. The word only adds clutter.
3. for parent files, the wording "subfiles" makes no sense at all, it never did. We all just got used to the ever same text on the PT pages.
Im not sure about "Parent". Any other suggestion?
Since I'm curious, PM me you other minor suggestions.
(2019-06-18, 21:08)Magnus Forsberg Wrote: The pages feels longer, I need to scroll more.
I like that some words have been emphasized.
Could we have the same on the words "a new version" of the file was submitted ?
They are a bit longer. There’s more whitespace for one. Not a lot more but it’s there. Also the fonts are a bit bigger as well. Third, the actual page is constrained to a smaller small. Again, not hugely small except for the largest of monitors. All in all I think it’s a small price to pay to be able to use the tracker on mobile and to have modern markup that is unified across the PT and main site.
(2019-06-19, 22:35)Damien Roux Wrote: On Firefox, the history graph is too large and I can't see the right part of it (it is out of the screen) and I got no way to scroll horizontally.
Yah. I noted that above. It’s the last major error I need to fix. Should prolly have that done in a few days. The rest of the work is finding and fixing errors on mobile and updating old markup.