6192.dat has invalid matrices

[Roland Melkert]

6192.dat seems broken, but it is so old I was doubting LDCad's detection.

LDView doesn't issue warnings though.

But line 68 is certainly wrong: 1 16 36 20 0 0 0 0 0 0 -16 -16 0 0 2-4edge.dat

Code:

35950 | 2023-07-04_01:37:17 | Progress | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Starting
35951 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 13 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 6]" to "[6 0 0] [0 0.95515733 1.86] [0 -0.29609877 6]"
35952 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 14 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 -6]" to "[6 0 0] [0 -0.95515733 1.86] [0 -0.29609877 -6]"
35953 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 17 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 6]" to "[6 0 0] [0 0.95515733 1.86] [0 -0.29609877 6]"
35954 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 18 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 -6]" to "[6 0 0] [0 -0.95515733 1.86] [0 -0.29609877 -6]"
35955 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 21 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 6]" to "[6 0 0] [0 0.95515733 1.86] [0 -0.29609877 6]"
35956 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 22 | Invalid matrix detected, corrected from "[6 0 0] [0 0 1.86] [0 0 -6]" to "[6 0 0] [0 -0.95515733 1.86] [0 -0.29609877 -6]"
35957 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 26 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 8]" to "[8 0 0] [0 0.95515733 2.48] [0 -0.29609877 8]"
35958 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 27 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 -8]" to "[8 0 0] [0 -0.95515733 2.48] [0 -0.29609877 -8]"
35959 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 30 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 8]" to "[8 0 0] [0 0.95515733 2.48] [0 -0.29609877 8]"
35960 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 31 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 -8]" to "[8 0 0] [0 -0.95515733 2.48] [0 -0.29609877 -8]"
35961 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 34 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 8]" to "[8 0 0] [0 0.95515733 2.48] [0 -0.29609877 8]"
35962 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 35 | Invalid matrix detected, corrected from "[8 0 0] [0 0 2.48] [0 0 -8]" to "[8 0 0] [0 -0.95515733 2.48] [0 -0.29609877 -8]"
35963 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 68 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -16] [-16 0 0]" to "[0 1 0] [0 0 -16] [-16 0 0]"
35964 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 69 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -16] [-16 0 0]" to "[0 1 0] [0 0 -16] [-16 0 0]"
35965 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 76 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -20] [-20 0 0]" to "[0 1 0] [0 0 -20] [-20 0 0]"
35966 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 77 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -20] [-20 0 0]" to "[0 1 0] [0 0 -20] [-20 0 0]"
35967 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 84 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -16] [-16 0 0]" to "[0 1 0] [0 0 -16] [-16 0 0]"
35968 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 85 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -16] [-16 0 0]" to "[0 1 0] [0 0 -16] [-16 0 0]"
35969 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 88 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -20] [-20 0 0]" to "[0 1 0] [0 0 -20] [-20 0 0]"
35970 | 2023-07-04_01:37:17 | Warning  | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | line 89 | Invalid matrix detected, corrected from "[0 0 0] [0 0 -20] [-20 0 0]" to "[0 1 0] [0 0 -20] [-20 0 0]"
35971 | 2023-07-04_01:37:17 | Progress | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Using shadow file "D:\XZale\interneProjecten\cpp\LDCad\1.7\bin\seeds\shadow\offLib\gitRepo\parts\6192.dat".
35972 | 2023-07-04_01:37:17 | Info     | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Appended 8 lines from the shadow file to this file.
35973 | 2023-07-04_01:37:17 | Info     | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Subfile needs rendering preparation.
35974 | 2023-07-04_01:37:17 | Info     | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Subfile is a part level object
35975 | 2023-07-04_01:37:17 | Progress | LDraw file load | D:\ldraw\complete-2303.zip\ldraw\parts\6192.dat | Done

[Travis Cobbs]

6192.dat seems broken, but it is so old I was doubting LDCad's detection.

LDView doesn't issue warnings though.

LDView contains code in LDModelLine.cpp to fix invalid matrices. It probably should issue a warning when it runs into them, but doesn't do so. I think that this was quite common back when this code was written, which based on git blame was 18 years ago. (I think it was so common that I felt that issuing a warning about it would do more harm than good.)

[Philippe Hurbain]

LDView contains code in LDModelLine.cpp to fix invalid matrices. It probably should issue a warning when it runs into them, but doesn't do so. I think that this was quite common back when this code was written, which based on git blame was 18 years ago. (I think it was so common that I felt that issuing a warning about it would do more harm than good.)

Yes it was extremely common then, most parts have been fixed since, but...

[Orion Pobursky]

Someone send me a correction.

I though we caught all these errors but apparently not. I'll put this issue to bed when I run the entire library through the updated error checker that's in progress.

[Gerald Lasser]

6192 plus subfile is on the tracker since quite some time...