LDInspector


RE: LDInspector version 0.2
Hi Willy, hi all,

thanks again for your detailed notes.  Smile  Most of them I tried to handle for the current version which is online right now:

(2020-04-08, 11:52)Willy Tschager Wrote: * The installation under win was smooth but you should add a note to the wiki in case the install.bat is stored in the program folder it has to be run with admin privileges.
Done.

(2020-04-08, 11:52)Willy Tschager Wrote: * I'm still confused that something like the Workspace is positioned on the left border and not the items section I work with every day
Modified positioning. My first intention was to guide the new user from left to right in the tool bar, but you are right: most users will be used to have items left.

(2020-04-08, 11:52)Willy Tschager Wrote: * After setting workspace for the first time it should be automatically saved (to <user>\Appdata)at the closing of the dialog.
LDInspector now asks for configuration saving if it was started without configuration. At the moment the save dialog uses the "current directory" and not <user>\Appdata because I like the idea of having something portable. If LDInspector is "installed" on a portable medium like an USB stick, the configuration should go there in my oppinion.

(2020-04-08, 11:52)Willy Tschager Wrote: * I do not like the fact that my file is overwritten right away and that no backup is created. I would prefer a Save button, which saves all the modification at the very end.
I completely rewrote the concept of writing to files. The red buttons now do not overwrite the file, all changes are in memory until you activate "Save" button on the Item pane. This is much better, but I still don't like the current behavior of LDInspector to close or refresh without notice or confirmation if there is unsaved data. This needs some more work...

(2020-04-08, 11:52)Willy Tschager Wrote: * I don't like the order how the checks are presented. A mirrored part to me is secondary, while a correct header is key.
The mirror check is moved downwards and mirrors of the same part only take one line per sub-model, so output flooding as with LS60 in your example should be cured.

(2020-04-08, 11:52)Willy Tschager Wrote: * 0 FILE 364 - Harbour Scene - Warehouse - String.ldr has (among other things a license issue) The quickfix confirmed that a licences has been added but didn't show up in Source. I had to load another subfile and then reload the String to get rid of the error in the OMR-check
* My .mpd will never be OMRized because of: "error: file contains sub-parts, but filename does not end with .mpd"
* Does not update .mpd content after unofficial files have been imported
Double checked these three, but could not reproduce it with my current version.

(2020-04-08, 11:52)Willy Tschager Wrote: * FIlename of imported unofficial files is wrong.
* Complains about filename s\364 - u572p02s01.dat does not start with parent OMR prefix "364 - "
I rewrote most of the code for filename checking and filename generating. Hopefully it is better starting with the current version!  Smile

(2020-04-08, 11:52)Willy Tschager Wrote: * Does not check for: 0 ROTATION CENTER 0 0 0 1 "Custom", 0 ROTATION CONFIG 0 0
I added a quick check for "unexpected" metas, but it only showed that I didn't understand the LDraw file format, yet.  Sad  So the current version does some checks, but the checks are not valid at the moment - instead they prove invalid file reading by the LDInspector LDraw parser. Especially unexpected meta lines before the description meta, but also even before the author meta breakes LDInspector edit code:

Code:
0 FILE 4565 - station - crane.ldr
0 !LEOCAD MODEL BACKGROUND GRADIENT 0 0 0.74902 1 1 1
0 station - crane
0 Name: 4565 - station - crane.ldr
This breakes because LDInspector requires the first non-file-meta to be the description at the moment, so "!LEOCAD" is taken as description by accident. Even worse, the name tag is not written back correctly because my understand until last week  Blush  was that the header lines are always fixed. My only source of LDraw models is LDCad, which generates only very nice files. Smile Additionally, reading the article https://forums.ldraw.org/thread-23904.html makes me thinking of re-writing the case-sensitivity of my parser. Sad  I know, the file format is "grown historically", but making a difference between "0 FILE" and "0 File" depending on existence of other metas does not make me feel happy.

This leads to another substantial question: at the moment, LDInspector does only minimal change, i.e. writing a file will keep as many original lines as possible. Even correctly parsed files are not completely rebuild from the parsed structure but original source code will be inserted - for example to avoid floating point precision loss and to keep intentional formatting or comments. But with all those "special quirks" (with my understanding of last week) at least the meta handling has to be re-done. Even if all LDraw software would produce such nice files as LDCad does - "old files" should work with LDInspector, too. I would like to do the header parsing again, but at the moment I feel that I still don't understand all meta considerations.

Long story short: I will test some more officially released OMR files, but Willy's hint to un-OMR-ized 364 was extremely helpful. Smile  So if you have non-LDCad-files that should be "ok" or have still known issues and that break LDInspector in some way, they most likely will be very helpful, too.

Thanks for all your feedback helping me on my way towards LDInspector 0.3...  Wink
Reply
« Next Oldest | Next Newest »



Messages In This Thread
LDInspector - by Stefan Frenz - 2020-02-07, 21:50
RE: LDInspector - by Stefan Frenz - 2020-02-07, 22:16
RE: LDInspector - by Stefan Frenz - 2020-02-11, 10:17
RE: LDInspector - by N. W. Perry - 2020-02-08, 5:39
RE: LDInspector - by Stefan Frenz - 2020-02-08, 8:31
RE: LDInspector - by Magnus Forsberg - 2020-02-08, 11:20
RE: LDInspector - by Stefan Frenz - 2020-02-08, 15:37
RE: LDInspector - by Magnus Forsberg - 2020-02-08, 17:34
RE: LDInspector - by Stefan Frenz - 2020-02-09, 14:23
RE: LDInspector - by Orion Pobursky - 2020-02-09, 14:43
RE: LDInspector - by Stefan Frenz - 2020-02-09, 15:58
RE: LDInspector - by Magnus Forsberg - 2020-02-09, 17:22
RE: LDInspector - by Stefan Frenz - 2020-03-09, 7:15
RE: LDInspector - by Philippe Hurbain - 2020-03-09, 8:28
RE: LDInspector - by Stefan Frenz - 2020-03-10, 22:37
RE: LDInspector - by N. W. Perry - 2020-02-08, 14:17
RE: LDInspector - by Willy Tschager - 2020-02-08, 9:41
RE: LDInspector - by Stefan Frenz - 2020-02-08, 9:49
RE: LDInspector - by Willy Tschager - 2020-02-11, 17:28
RE: LDInspector - by Stefan Frenz - 2020-02-11, 18:57
RE: LDInspector - by Willy Tschager - 2020-02-12, 7:31
RE: LDInspector - by Stefan Frenz - 2020-02-12, 7:50
RE: LDInspector - by Stefan Frenz - 2020-02-13, 9:36
RE: LDInspector - by Willy Tschager - 2020-02-13, 20:40
RE: LDInspector - by Stefan Frenz - 2020-02-14, 6:21
RE: LDInspector - by Stefan Frenz - 2020-02-14, 15:14
RE: LDInspector - by Willy Tschager - 2020-02-15, 17:26
RE: LDInspector - by Stefan Frenz - 2020-02-15, 19:27
RE: LDInspector - by Stefan Frenz - 2020-02-21, 9:41
RE: LDInspector - by Willy Tschager - 2020-02-21, 14:16
RE: LDInspector - by Stefan Frenz - 2020-02-21, 14:27
RE: LDInspector - by Willy Tschager - 2020-02-23, 9:48
RE: LDInspector - by Stefan Frenz - 2020-02-23, 11:36
RE: LDInspector - by Willy Tschager - 2020-02-25, 11:27
RE: LDInspector - by Philippe Hurbain - 2020-02-25, 15:38
RE: LDInspector - by Stefan Frenz - 2020-02-25, 15:47
RE: LDInspector - by Philippe Hurbain - 2020-02-25, 16:14
RE: LDInspector - by Philippe Hurbain - 2020-02-25, 17:20
RE: LDInspector - by Stefan Frenz - 2020-02-25, 17:30
RE: LDInspector - by Stefan Frenz - 2020-02-14, 15:15
RE: LDInspector - by N. W. Perry - 2020-02-14, 16:16
RE: LDInspector - by Stefan Frenz - 2020-02-14, 16:37
RE: LDInspector - by N. W. Perry - 2020-02-25, 17:49
RE: LDInspector - by Stefan Frenz - 2020-02-25, 17:56
RE: LDInspector - by N. W. Perry - 2020-02-25, 21:15
RE: LDInspector - by Stefan Frenz - 2020-02-25, 21:37
RE: LDInspector - by N. W. Perry - 2020-02-26, 21:07
RE: LDInspector - by Stefan Frenz - 2020-02-26, 21:19
RE: LDInspector - by N. W. Perry - 2020-02-27, 1:01
RE: LDInspector - by Stefan Frenz - 2020-02-27, 8:16
RE: LDInspector - by N. W. Perry - 2020-03-02, 17:25
RE: LDInspector - by Stefan Frenz - 2020-03-03, 6:35
RE: LDInspector - by N. W. Perry - 2020-04-04, 21:55
RE: LDInspector - by Philippe Hurbain - 2020-02-27, 8:47
RE: LDInspector - by Stefan Frenz - 2020-02-27, 9:51
RE: LDInspector - by Philippe Hurbain - 2020-02-27, 10:11
RE: LDInspector - by Stefan Frenz - 2020-02-27, 13:11
RE: LDInspector - by Orion Pobursky - 2020-02-27, 13:33
RE: LDInspector - by Stefan Frenz - 2020-02-27, 13:45
RE: LDInspector - by Stefan Frenz - 2020-02-27, 14:32
RE: LDInspector - by Philippe Hurbain - 2020-02-27, 14:50
RE: LDInspector - by Stefan Frenz - 2020-02-15, 7:00
RE: LDInspector - by Willy Tschager - 2020-02-25, 11:29
RE: LDInspector - by Stefan Frenz - 2020-02-25, 13:10
RE: LDInspector - by Orion Pobursky - 2020-02-25, 14:10
RE: LDInspector - by Stefan Frenz - 2020-02-27, 14:30
RE: LDInspector - by Orion Pobursky - 2020-02-27, 15:00
RE: LDInspector - by Stefan Frenz - 2020-02-26, 19:42
RE: LDInspector - by Stefan Frenz - 2020-02-28, 15:47
RE: LDInspector - by Willy Tschager - 2020-02-25, 11:51
RE: LDInspector - by Stefan Frenz - 2020-02-25, 13:08
RE: LDInspector - by Stefan Frenz - 2020-03-04, 16:15
RE: LDInspector - by Stefan Frenz - 2020-03-10, 22:35
RE: LDInspector - by Stefan Frenz - 2020-03-16, 7:16
RE: LDInspector - by N. W. Perry - 2020-03-19, 1:39
RE: LDInspector - by Stefan Frenz - 2020-03-19, 6:23
RE: LDInspector - by N. W. Perry - 2020-03-20, 1:19
RE: LDInspector - by Stefan Frenz - 2020-04-04, 14:05
RE: LDInspector - by N. W. Perry - 2020-04-05, 1:24
LDInspector version 0.2 - by Stefan Frenz - 2020-04-01, 9:21
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-04, 13:40
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-04, 13:52
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-08, 12:37
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-12, 13:01
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-12, 14:41
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-13, 19:49
Header Meta question - by Stefan Frenz - 2020-04-30, 12:34
RE: Header Meta question - by Stefan Frenz - 2020-05-02, 9:53
RE: Header Meta question - by Orion Pobursky - 2020-05-02, 12:42
RE: Header Meta question - by Stefan Frenz - 2020-05-02, 13:13
RE: Header Meta question - by Leonardo Zide - 2020-05-03, 16:27
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-12, 13:10
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-04-14, 8:18
current version update - by Stefan Frenz - 2020-04-26, 14:20
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-05-01, 15:54
RE: LDInspector version 0.2 - by Stefan Frenz - 2020-05-01, 18:59
RE: LDInspector - by Michael Heidemann - 2020-04-12, 20:20
RE: LDInspector - by Stefan Frenz - 2020-04-13, 6:12
LDInspector version 0.3 - by Stefan Frenz - 2020-05-06, 16:54
RE: LDInspector - by N. W. Perry - 2020-05-06, 20:31
RE: LDInspector - by Stefan Frenz - 2020-05-07, 5:10
RE: LDInspector - by N. W. Perry - 2020-05-07, 15:27
RE: LDInspector - by Stefan Frenz - 2020-08-17, 9:56
RE: LDInspector - by Lasse Deleuran - 2020-08-17, 12:05
RE: LDInspector - by Stefan Frenz - 2020-08-17, 12:34
RE: LDInspector - by Orion Pobursky - 2020-08-17, 14:03
RE: LDInspector - by Stefan Frenz - 2020-08-17, 14:52
RE: LDInspector - by Orion Pobursky - 2020-08-17, 14:57
RE: LDInspector - by Stefan Frenz - 2020-08-17, 15:43
RE: LDInspector - by Stefan Frenz - 2020-08-18, 10:27
RE: LDInspector - by Stefan Frenz - 2020-08-29, 21:43
RE: LDInspector - by rajubhaiya - 2020-09-24, 20:00
RE: LDInspector - by Stefan Frenz - 2020-09-25, 6:49
LDInspector version 0.4 - by Stefan Frenz - 2020-10-02, 17:41
RE: LDInspector - by singhudit - Yesterday, 14:32

Forum Jump:


Users browsing this thread: 1 Guest(s)