RE: Shadow file contributions
2024-05-18, 19:55 (This post was last modified: 2024-05-18, 19:57 by Roland Melkert.)
2024-05-18, 19:55 (This post was last modified: 2024-05-18, 19:57 by Roland Melkert.)
I have merged your changes.
Some notes:
- You forgot some 'todo' history lines.
- Some antistuds used the square shape instead of round and vice versa.
- 80015 had some duplicate info, I moved most to the subpart.
On a side note I polluted your pr with some other maintenance changes (Still working on finding the best workflow for processing pr's
)
Also it might be easier to limit commits once you made the PR. Maybe make all your changes and do a PR once a week and start on another PR while I merge the previous one without having the risk of you adding something new to it at the same time.
PS I will add the unofficial status info to your parts later. Have to modify the shadow cleaning function first.
Some notes:
- You forgot some 'todo' history lines.
- Some antistuds used the square shape instead of round and vice versa.
- 80015 had some duplicate info, I moved most to the subpart.
On a side note I polluted your pr with some other maintenance changes (Still working on finding the best workflow for processing pr's
) Also it might be easier to limit commits once you made the PR. Maybe make all your changes and do a PR once a week and start on another PR while I merge the previous one without having the risk of you adding something new to it at the same time.
PS I will add the unofficial status info to your parts later. Have to modify the shadow cleaning function first.