Naming scheme for primitives - update


Naming scheme for primitives - update
#1
It seems that there is a need for updating the naming scheme that Primgen2 uses for the primitives.
Here my suggestion:
x, y, z are values that will be substituted by primgen2 for the dimension of the part.
cylinder: x-ycyli.dat : always use cyli
disc: x-ydisc.dat : always use disc
ndisc: x-yndis.dat : always use ndis
chord: x-ychrd.dat : always use chrd
cone: x-yconz.dat : always use con
ring:x-yringz.dat : always use ring
circle: x-yedge.dat : always use edge

The length of the filename is not important anymore because I think we will not reach 25 characters.

If this should be common used, I am going to change Primgen2 quickly.
Reply
Re: Naming scheme for primitives - update
#2
I am inclined to agree. Would somebody have time to assess the scope of impact on existing official primitives (ldraw/p and ldraw/p/48)?

Thanks for bringing this up for discussion.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#3
Analysis coming up. I can tell straight up, though, that changing 'rin' to 'ring' would be a massive change.
Reply
Re: Naming scheme for primitives - update
#4
Yes, that is true. With LDFind I made a quick search for 'ring' and found:
Hi-Res Ring 40 x 0.2292 C:\ldraw\p\48\11-48r40.dat
Hi-Res Ring 42 x 0.0833 C:\ldraw\p\48\1-12ri42.dat
Ring 11 x 0.25 C:\ldraw\p\1-4rin11.dat
Ring 8 x 0.375 C:\ldraw\p\3-8ring8.dat

So for ring we have at least 'r', 'ri', 'rin' and 'ring' already in our library.

I believe that for the other primitives we will have similar results. So we need to solve this problem first.

I would go with:
Keep the already official files like they are. Introduce the new naming scheme quickly for new primitives.
Reply
Re: Naming scheme for primitives - update
#5
Okay so, assuming we leave 'rin' files alone since there's just too many of those to even consider it IMO: I found 51 official primitives that would need renaming. A total of 25 part/subpart files would have to be updated accordingly:

List of primitives:
Code:
13-16chr.dat
48\11-24cyl.dat
48\11-24edg.dat
48\11-24r13.dat
48\11-24r52.dat
48\1-12co24.dat
48\1-12ri17.dat
48\1-12ri20.dat
48\1-12ri38.dat
48\1-12ri42.dat
48\1-12ri78.dat
48\11-48r19.dat
48\11-48r40.dat
48\1-16co11.dat
48\1-16co19.dat
48\1-16co20.dat
48\1-16co24.dat
48\1-16ri13.dat
48\1-16ri14.dat
48\1-16ri19.dat
48\1-16ri21.dat
48\1-16ri43.dat
48\1-24co10.dat
48\1-24co12.dat
48\1-24co14.dat
48\1-24co16.dat
48\1-24co24.dat
48\1-24ri11.dat
48\1-24ri19.dat
48\1-48ri43.dat
48\19-48edg.dat
48\2-4ri240.dat
48\3-16co19.dat
48\4-4ri100.dat
48\5-12ri13.dat
48\5-12ri14.dat
48\5-24co10.dat
48\5-24co12.dat
48\5-24co14.dat
48\5-24co16.dat
48\5-24ri10.dat
48\5-24ri17.dat
48\5-24ri18.dat
48\5-24ri20.dat
48\5-24ri24.dat
48\5-24ri28.dat
48\5-24ri29.dat
48\5-48co12.dat
48\5-48co29.dat
48\5-48ri32.dat
48\7-16ri16.dat

List of affected part files:
Code:
parts/2431pc0.dat
parts/2745.dat
parts/3942bp01.dat
parts/41667.dat
parts/43373.dat
parts/44224.dat
parts/4613.dat
parts/54715.dat
parts/59826ac01.dat
parts/6542a.dat
parts/84752.dat
parts/88492.dat
parts/88493.dat
parts/95188.dat
parts/99378.dat
parts/99551.dat
parts/s/10131s01.dat
parts/s/2431pt2b.dat
parts/s/2870s01.dat
parts/s/30535s01.dat
parts/s/3739a.dat
parts/s/43373s01.dat
parts/s/61481s00.dat
parts/s/86500s01.dat
parts/s/99010s01.dat
parts/u9166.dat

List of matches, sans duplicates (which parts referenced which primitives):
Code:
parts/2431pc0.dat:13-16chr.dat
parts/2745.dat:48\3-16co19.dat
parts/3942bp01.dat:48\1-24co10.dat
parts/3942bp01.dat:48\1-24co12.dat
parts/3942bp01.dat:48\1-24co14.dat
parts/3942bp01.dat:48\1-24co16.dat
parts/3942bp01.dat:48\5-24co10.dat
parts/3942bp01.dat:48\5-24co12.dat
parts/3942bp01.dat:48\5-24co14.dat
parts/3942bp01.dat:48\5-24co16.dat
parts/41667.dat:48\11-48r19.dat
parts/41667.dat:48\11-48r19.dat
parts/41667.dat:48\11-48r40.dat
parts/41667.dat:48\11-48r40.dat
parts/43373.dat:48\5-24ri24.dat
parts/44224.dat:48\1-16ri13.dat
parts/44224.dat:48\1-16ri14.dat
parts/4613.dat:48\5-12ri13.dat
parts/4613.dat:48\5-12ri14.dat
parts/54715.dat:48\1-16ri21.dat
parts/59826ac01.dat:48\2-4ri240.dat
parts/6542a.dat:48\4-4ri100.dat
parts/84752.dat:48\1-24co16.dat
parts/88492.dat:48\1-24ri11.dat
parts/88493.dat:48\11-24cyl.dat
parts/88493.dat:48\11-24edg.dat
parts/95188.dat:48\5-24ri20.dat
parts/95188.dat:48\5-24ri28.dat
parts/95188.dat:48\5-24ri29.dat
parts/99378.dat:48\5-48co12.dat
parts/99551.dat:48\1-16ri13.dat
parts/99551.dat:48\5-24ri20.dat
parts/s/10131s01.dat:48\5-24ri10.dat
parts/s/2431pt2b.dat:48\5-48ri32.dat
parts/s/2870s01.dat:48\11-24cyl.dat
parts/s/2870s01.dat:48\11-24edg.dat
parts/s/2870s01.dat:48\11-24edg.dat
parts/s/2870s01.dat:48\11-24r13.dat
parts/s/2870s01.dat:48\11-24r52.dat
parts/s/2870s01.dat:48\19-48edg.dat
parts/s/2870s01.dat:48\7-16ri16.dat
parts/s/30535s01.dat:48\11-24edg.dat
parts/s/30535s01.dat:48\5-24ri17.dat
parts/s/30535s01.dat:48\5-24ri18.dat
parts/s/3739a.dat:48\1-12co24.dat
parts/s/3739a.dat:48\1-12ri17.dat
parts/s/3739a.dat:48\1-12ri20.dat
parts/s/3739a.dat:48\1-12ri20.dat
parts/s/3739a.dat:48\1-12ri42.dat
parts/s/3739a.dat:48\1-24co24.dat
parts/s/43373s01.dat:48\1-16co24.dat
parts/s/61481s00.dat:48\1-16co19.dat
parts/s/61481s00.dat:48\1-16co20.dat
parts/s/86500s01.dat:48\1-12ri38.dat
parts/s/86500s01.dat:48\1-12ri78.dat
parts/s/99010s01.dat:48\1-16co11.dat
parts/s/99010s01.dat:48\1-16co19.dat
parts/s/99010s01.dat:48\1-16co20.dat
parts/s/99010s01.dat:48\1-16ri19.dat
parts/s/99010s01.dat:48\1-16ri43.dat
parts/s/99010s01.dat:48\5-48co29.dat
parts/u9166.dat:48\1-24ri19.dat
parts/u9166.dat:48\1-48ri43.dat
Reply
Re: Naming scheme for primitives - update
#7
That is actually not too bad. I can create the new files by renaming the existing ones, so please don't start submitting replacements.

I'd like to leave "~Moved to" files in place so that we don't have to fix all the official parts/subparts in one tranche. It is inevitable that when the parts get re-cycled through the Parts Tracker, someone will want to make improvements which could hold up the whole process.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#8
Does the parts tracker already check for usage of "~Moved to" sub-parts and primitives in submitted parts and auto-generate a failure?
Reply
Re: Naming scheme for primitives - update
#9
No - not at present.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#10
All the "moves" have now been done on the Parts Tracker. I've not yet checked if there are any unofficial primitives that need renaming.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#11
I don't understand this.

Is it correct that all the hi-res prims are renumbered without a moved to-file?
Is it correct that all the hi-res prims should have both "Unofficial_48_Primitive" and a "UPDATE YYYY-XX" ?
Is it correct that the only normal resolution primitive should have a "Moved to-" file?
Reply
Re: Naming scheme for primitives - update
#12
Magnus Forsberg Wrote:Is it correct that all the hi-res prims are renumbered without a moved to-file?
No, the ~Moved to files are there e.g. http://www.ldraw.org/cgi-bin/ptdetail.cg...48ri32.dat, but the Name: line hasn't been updated correctly (I'll fix that).
Magnus Forsberg Wrote:Is it correct that all the hi-res prims should have both "Unofficial_48_Primitive" and a "UPDATE YYYY-XX" ?
No, that's a bug in the rename script (probably the first time it has been used on a p/48/ file)
Magnus Forsberg Wrote:Is it correct that the only normal resolution primitive should have a "Moved to-" file?
Not sure what you mean. Can you point to an example?
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#14
OK, thanks.
When I wrote this none of the hi-res had a move to-file. They do now.

Mike found this strange file, and I found that the only file that got a moved to-file was this one.
It still has an incorrect header. Could you please fix that one too?
Reply
Re: Naming scheme for primitives - update
#15
As fas as I can see both files are now fine.
Reply
Re: Naming scheme for primitives - update
#13
Ok, it seems I have to update PrimGen2 immediately.

Before I upload it I like someone to test it. Who likes to test the new version??

Edit:
The new version is already online. Please see this post.
Reply
Re: Naming scheme for primitives - update
#16
I think I've found some more files.

Official files
p\1-16ri19.dat
p\3-16ri11.dat
p\3-16ri12.dat
p\3-16ri13.dat
p\3-16ri14.dat
p\5-16ri12.dat

p\48\19-48chr.dat

Unofficial files
p\1-16ri11.dat
p\1-16ri22.dat
p\1-16ri57.dat
p\3-16ri10.dat
p\3-16ri15.dat
p\3-16ri19.dat
p\3-16ri22.dat
p\4-4ri101.dat

p\48\4-4cone25.dat
p\48\4-4cone52.dat

and one of the files p\13-16cyl.dat or p\13-16cyli.dat should be deleted/renumbered
and p\11-16cyl.dat should be renumbered
Reply
Re: Naming scheme for primitives - update
#17
Thanks - done.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#18
I've found another two files that IMO should not be renumbered.

Unofficial
p\48\1-4cone12.dat
p\48\1-6cone1.dat

Michael Heidemann Wrote:cone: x-yconz.dat : always use con

Please change them back to 1-4con12.dat and 1-6con1.dat
Reply
Re: Naming scheme for primitives - update
#19
That's done.
Chris (LDraw Parts Library Admin)
Reply
Re: Naming scheme for primitives - update
#6
Why don't we create MOVEDTOs? Then all new parts will use the new scheme and all old parts will be fine until updated
Reply
« Next Oldest | Next Newest »



Forum Jump:


Users browsing this thread: 1 Guest(s)
Forum Jump:


Users browsing this thread: 1 Guest(s)