LDCad Shadow file contributions


RE: Shadow file contributions
#14
(2024-05-18, 19:55)RolandĀ Melkert Wrote: I have merged your changes.

Some notes:
- You forgot some 'todo' history lines.
- Some antistuds used the square shape instead of round and vice versa.
- 80015 had some duplicate info, I moved most to the subpart.

On a side note I polluted your pr with some other maintenance changes (Still working on finding the best workflow for processing pr'sĀ  Big Grin )

Also it might be easier to limit commits once you made the PR. Maybe make all your changes and do a PR once a week and start on another PR while I merge the previous one without having the risk of you adding something new to it at the same time.

PS I will add the unofficial status info to your parts later. Have to modify the shadow cleaning function first.
Thanks! Yes I could certainly do that. Still learning so I was guess that some stuff was wrong. I'm glad you decided to add unofficial parts! Smile

Looking forward to that change and will do my best to keep helping get more parts out.
Reply
« Next Oldest | Next Newest »



Messages In This Thread
RE: Shadow file contributions - by Fredrik Hareide - 2024-05-20, 4:57

Forum Jump:


Users browsing this thread: 1 Guest(s)