Auto correcting (some) defects in the official library

Re: Resulting patch (was Re: Auto correcting..)
Quote:Is looks as if it tried to fix concave quad, but failed, and made it worse. The 'fixed' file still have the same number of concave quad, but now have the vertices in another order.
It thinks it's a twisted quad because the algorithm tests this by splitting the quad in two triangles which in case of a concave can end up having different windings. It then swaps some points and tests again, the first order where both triangles have the same winding wins but in case of a concave nothing is really fixed Smile

So what's really lacking here is a concave detection instead of a twisted quad detection.

Thanks for spotting/manually fixing this, please remove the libfix history line from this file as it didn't help in anyway.
« Next Oldest | Next Newest »

Messages In This Thread
Re: Resulting patch (was Re: Auto correcting..) - by Roland Melkert - 2015-01-19, 18:13

Forum Jump:

Users browsing this thread: 1 Guest(s)