LDraw.org Discussion Forums
[LSC Request] End of header meta command - Printable Version

+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: Models and Parts (https://forums.ldraw.org/forum-18.html)
+--- Forum: Parts Authoring (https://forums.ldraw.org/forum-19.html)
+--- Thread: [LSC Request] End of header meta command (/thread-8081.html)

Pages: 1 2 3 4 5 6 7 8 9


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Steffen - 2014-01-15

Whoah, Arthur, your reaction is by far too harsh.
I can only ask you to step back a little and reconsider.
Remember that we're discussing here a file standard used by thousands of users.
You must allow that an extensive discussion of such syntax extensions happens,
and also, that opposite opinions to yours are allowed to be said and heard the same way as yours is.
I am not an English native speaker, so when using the wording "keyword clutter" I did not intend a pun alongside with it.
I just wanted to express that we should be careful of minimizing the amount of specified keywords.
And on the introduction of each one, carefully consider.
There's no personal controversy going on here, especially not against you. All being said here is just exchanging
logical / technical arguments and counterarguments.
Take a deep breath and maybe a break of some days and then stay with us.


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Chris Dee - 2014-01-15

It is still work that needs some manual intervention.

If it were possible to algorithmically determine where to insert the End-of-Header statement, it wouldn't actually need doing. Any files with "0 //" comments immediately following the !HISTORY will need to be reviewed to assess whether those are "Needs work" comments or "part content" comments, and the position of the End-of-Header statement adjusted.


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Orion Pobursky - 2014-01-15

Point taken. However, for ease of parsing we should either a) have a end of header meta or b) have everything in the header have a header only meta (ie have a meta that is only used in the header.


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Chris Dee - 2014-01-16

Are you are suggesting a fourth option:

4) Define a "needs work" meta-statement update all (Needs Work) files and define an end-of-header meta statement and apply it to every part.
The end-of header algorithm would then be the detection of that statement. This would require the re-issue of the entire library in a Parts Update.
Algorithm clarity: high, Implementation effort: medium-high (programmatic plus manual update of probably > 154 official files).


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Orion Pobursky - 2014-01-16

No what I'm saying is either:

a) Have a EOH meta

-or-

b) Have every line in the header be under a meta that is illegal to be found outside of the header. This way once the first line without a header meta is encountered, that's the end of the header.

a is more futureproof that b but b requires less parts reissue. Personally, I don't see a problem with reissuing the entire library but some may object so I offer b as an alternative.


Re: [LSC Request] End of header meta command - Michael Heidemann - 2014-01-16

This problem is designed with our current header and the forced comment for "needs work" explanations.

Code:
0 !HISTORY YYYY-MM-DD {RealName} Free text description of change

0 // Comments

If we agree on "needs work" comments needs to be mentioned before the !HISTORY lines all our problems are gone.
After the last !HISTORY line the header is finished.

Code:
0 // Needs work comments

0 !HISTORY YYYY-MM-DD {RealName} Free text description of change

0 // Comments



Re: [LSC Request] End of header meta command - Roland Melkert - 2014-01-16

This is similar to what I suggested here:

http://forums.ldraw.org/showthread.php?tid=8133&pid=8133#pid8133

It would solve both the presentation and clutter problem.


Re: Call for LSC Vote Re: [LSC Request] End of header meta command - Chris Dee - 2014-01-17

Orion Pobursky Wrote:a) Have a EOH meta
= option 3 here

Orion Pobursky Wrote:b) Have every line in the header be under a meta that is illegal to be found outside of the header. This way once the first line without a header meta is encountered, that's the end of the header.
I believe the only untagged header content is "Needs work" comments, so = option 1 here