+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: General (https://forums.ldraw.org/forum-12.html)
+--- Forum: Parts Tracker Discussion (https://forums.ldraw.org/forum-36.html)
+--- Thread: Next Release Primary Focus: Axleholes (/thread-26027.html)
Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-09
We need to focus on certifying all the official part fixes for:
axlehole
axlehol2
axlehol3
axlehol4
axlehol5
axlehol6
axlehol8
axl5end
I don't want to hold these back from release.
Right now the only official part fix with a hold vote is /s/57028s01.dat, the rest just need votes.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-09
Here's a link to all the parts that need attention:
https://www.ldraw.org/cgi-bin/ptreviewsummary.cgi?f=axleholefix
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-09
(2022-02-09, 21:02)Orion Pobursky Wrote: Here's a link to all the parts that need attention:
https://www.ldraw.org/cgi-bin/ptreviewsummary.cgi?f=axleholefix
This link is blocked by my viewer, Firefox. Something triggers a block to open that summary page.
But if I go to the startpage of the Part Tracker, I can use that link to open it.
And some of the links on the summary page trigger a download, and some link goes to the part page.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-09
The page layout sucks as this escaped my attention when I reformatted the PT. I'll be cleaning up the HTML to make it more usable but for the mean time:
The "filename" links to a download. The "description" links to the part page.
Not sure why your browser is complaining about the link.
Edit: Fixed problem with the link on this post. Not sure what caused it.
Edit 2: HTML on the summary page is better.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-09
(2022-02-09, 22:21)Orion Pobursky Wrote: Edit: Fixed problem with the link on this post. Not sure what caused it.
Yes, seems to work better now.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-10
(2022-02-09, 5:53)Orion Pobursky Wrote: Right now the only official part fix with a hold vote is /s/57028s01.dat, the rest just need votes.
I suggest obsoleting the official files and create a set of 57028p01-p04, but what numbers should be used on the new subfiles?
https://brickset.com/parts/design-57028
We have a similar naming on 76110, and using p01-p04 could be used here to.
I can do the rework.
RE: Next Release Primary Focus: Axleholes - Philippe Hurbain - 2022-02-11
(2022-02-10, 21:18)Magnus Forsberg Wrote: I suggest obsoleting the official files and create a set of 57028p01-p04, but what numbers should be used on the new subfiles?imho 57028as01/s02 for the updated subparts, p01/p04 for parts and obsoletize all previous files.
https://brickset.com/parts/design-57028
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-25
Thanks for all the effort so far. We're almost there. Let's push the last ones through. I'd like to the March release the weekend of the 12th
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-27
Yes, very glad to see so many files allready certified, but there are still some loose subfiles at the end of this list.
https://www.ldraw.org/cgi-bin/ptreviewsu...xleholefix
Please give them a look over and review.
RE: Next Release Primary Focus: Axleholes - Philippe Hurbain - 2022-02-27
(2022-02-27, 11:20)Magnus Forsberg Wrote: Please give them a look over and review.I think the (non-admin) review task is completed now. Otherwise please list files in need of attention!
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-27
(2022-02-27, 15:32)Philippe Hurbain Wrote: I think the (non-admin) review task is completed now. Otherwise please list files in need of attention!
The following have either a hold vote or need another certify:
p/clh3.dat (holding up 30552.dat)
parts/s/6042s01.dat (holding up 6042.dat)
parts/s/6042s03.dat (holding up 6042.dat)
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-27
(2022-02-27, 15:32)Philippe Hurbain Wrote: Otherwise please list files in need of attention!
How is that list generated?
If I open each primitive page I find a lot more files, both new and reworked, that need reviews.
6641 and 51149 needs better descriptions
6641, Technic Transmission Changeover Catch Type 1
51149, Technic Transmission Changeover Catch Type 2
and 51149 need two reviewer to have a look at it.
And 32074 (in the list) need more editing, or reviewing.
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/32074.dat
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-27
(2022-02-27, 17:32)Magnus Forsberg Wrote: How is that list generated?
If I open each primitive page I find a lot more files, both new and reworked, that need reviews.
6641 and 51149 needs better descriptions
6641, Technic Transmission Changeover Catch Type 1
51149, Technic Transmission Changeover Catch Type 2
and 51149 need two reviewer to have a look at it.
And 32074 (in the list) need more editing, or reviewing.
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/32074.dat
I manually generated it from the pre-release dependency script. There may be some parts that got missed. I'll double check and update the list.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-27
(2022-02-27, 17:40)Orion Pobursky Wrote: I manually generated it from the pre-release dependency script. There may be some parts that got missed. I'll double check and update the list.
I never checked it against my list. I'll do that.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-27
(2022-02-27, 21:50)Magnus Forsberg Wrote: I never checked it against my list. I'll do that
I updated the list. There were a few that slipped through the cracks. 51149 is not a part fix so is not included in the list.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-28
(2022-02-27, 23:36)Orion Pobursky Wrote: I updated the list.
I found a few more in my list.
Subparts; 3648as01, 3648s02, 6575s01, 6637s02, 24196s01, 43363s01
Parts; 6575, 47675
Most of these files had to be edited, but doesn't use any axlehole primitives.
6575 is now a Move to 6575a, and I made 6575b.
What to do with 47675?
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-02-28
(2022-02-28, 21:09)Magnus Forsberg Wrote: I found a few more in my list.
Subparts; 3648as01, 3648s02, 6575s01, 6637s02, 24196s01, 43363s01
Parts; 6575, 47675
Most of these files had to be edited, but doesn't use any axlehole primitives.
6575 is now a Move to 6575a, and I made 6575b.
What to do with 47675?
If they don't use axlehole prims, I'm not that concerned about them as changes to the prims won't affect the file geometry. Or I am missing something?
Edit: I will add 6575 and 6575a to the list.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-02-28
(2022-02-28, 21:20)Orion Pobursky Wrote: Or I am missing something?
They are all edited due to changed design of the axlehole.
These are all parts that have an axlehole, but due to the design around the axlehole can't use any axlehole primitives.
If they're not included these parts will have the old design.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-03-01
(2022-02-28, 21:54)Magnus Forsberg Wrote: They are all edited due to changed design of the axlehole.
These are all parts that have an axlehole, but due to the design around the axlehole can't use any axlehole primitives.
If they're not included these parts will have the old design.
Let me rephrase the question: will releasing the fix to the axlehole primitives adversely affect the geometry of the parts that the fixed axlehole doesn't use primitives?
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-03-01
(2022-03-01, 1:01)Orion Pobursky Wrote: Let me rephrase the question: will releasing the fix to the axlehole primitives adversely affect the geometry of the parts that the fixed axlehole doesn't use primitives?
I have to say Yes, some of the parts would have visible gaps or overlapping/overhanging surfaces.
Gaps between the axleholes inside the Vader helmet, 43363.
Surfaces around the axlehole inside the dragon head 24196.
Gaps inside the side axleholes on 6637e
and more.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-03-01
(2022-03-01, 17:33)Magnus Forsberg Wrote: I have to say Yes, some of the parts would have visible gaps or overlapping/overhanging surfaces.
Gaps between the axleholes inside the Vader helmet, 43363.
Surfaces around the axlehole inside the dragon head 24196.
Gaps inside the side axleholes on 6637e
and more.
Ok. I put them on the tracker when I updated yesterday.
RE: Next Release Primary Focus: Axleholes - Magnus Forsberg - 2022-03-01
(2022-03-01, 18:12)Orion Pobursky Wrote: Ok. I put them on the tracker when I updated yesterday.
Thanks.
RE: Next Release Primary Focus: Axleholes - Orion Pobursky - 2022-03-06
The last 2 parts that need certification for this:
parts/47675.dat
and
p/clh3.dat
I have determined that parts/32074.dat will not be adversely affected by the axlehole changes and can stay on the PT for other issues.