LDraw.org Discussion Forums
[LDView] LDView 4.4 Beta 4 test release - Printable Version

+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: LDraw Programs (https://forums.ldraw.org/forum-7.html)
+--- Forum: LDraw Editors and Viewers (https://forums.ldraw.org/forum-11.html)
+--- Thread: [LDView] LDView 4.4 Beta 4 test release (/thread-24607.html)

Pages: 1 2 3


RE: LDView 4.4 Beta 4 test release - Travis Cobbs - 2021-05-18

(2021-05-17, 21:17)Travis Cobbs Wrote: Thanks. I'll investigate. The previous chrd issue was caused by the clipping plane needing to swap to the opposite side of the origin for all chrd primitives that were more than half circles, so the fix was easy. (Note that this was always broken.) Hopefully this is a similar issue, with a similar fix.

The fix for this turned out to be a lot more complicated, but I was able to make it work. It will be fixed in the next release.


RE: LDView 4.4 Beta 4 test release - Magnus Forsberg - 2021-06-02

What is happening here?

https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/12818.dat

[Image: 12818.png]

The primitive substitution on this mixed-mode primitive is not made correctly. The issue is visible on the PT image, but when I open the part in the 3D preview it looks Ok. And it also looks good on my screen until I turn on the prim substitution in LDView.

It's also looking good on a pov-ray image.

   


RE: LDView 4.4 Beta 4 test release - Philippe Hurbain - 2021-06-02

Indeed... Looks like a scaling issue, the torus is still there but too small.


RE: LDView 4.4 Beta 4 test release - Magnus Forsberg - 2021-06-02

(2021-06-02, 16:22)Philippe Hurbain Wrote: Indeed... Looks like a scaling issue, the torus is still there but too small.

To me, it looks like it is replaced with something completely different.


RE: LDView 4.4 Beta 4 test release - Philippe Hurbain - 2021-06-02

(2021-06-02, 16:26)Magnus Forsberg Wrote: To me, it looks like it is replaced with something completely different.
No, it's just that minor radius is not properly scaled (major radius looks OK)


RE: LDView 4.4 Beta 4 test release - Travis Cobbs - 2021-06-02

(2021-06-02, 16:52)Philippe Hurbain Wrote: No, it's just that minor radius is not properly scaled (major radius looks OK)

I'll investigate. This isn't a new problem, as it affects old versions of LDView also. Having said that, "mixed mode" torus primitives (with a "tm" prefix) don't show up in the official primitives reference, and while LDView supports them, I don't remember how their filename is supposed to be formatted. I don't know if this is a case where the unofficial file tm04o2000.dat is broken, or LDView's parsing of its filename is broken. I would appreciate it if somebody pointed me to an explanation of how the filename is formatted. Also, these should be added to the official primitives reference.


RE: LDView 4.4 Beta 4 test release - Travis Cobbs - 2021-06-02

(2021-06-02, 22:50)Travis Cobbs Wrote: I'll investigate. This isn't a new problem, as it affects old versions of LDView also. Having said that, "mixed mode" torus primitives (with a "tm" prefix) don't show up in the official primitives reference, and while LDView supports them, I don't remember how their filename is supposed to be formatted. I don't know if this is a case where the unofficial file tm04o2000.dat is broken, or LDView's parsing of its filename is broken. I would appreciate it if somebody pointed me to an explanation of how the filename is formatted. Also, these should be added to the official primitives reference.

I found this:

https://forums.ldraw.org/thread-22187-post-25384.html#pid25384

Unless I'm misreading, the unofficial file tm04o2000.dat is mis-named. I believe that LDView is behaving correctly, and the file should be named rm04o2000.dat.

The name tm04o2000.dat describes a torus with a minor radius of 0.2 LDU, not 2 LDU like this file's header comment indicates. The name rm04o2000.dat represents a torus with a minor radius of 2 LDU.


RE: LDView 4.4 Beta 4 test release - Orion Pobursky - 2021-06-03

(2021-06-02, 23:03)Travis Cobbs Wrote: I found this:

https://forums.ldraw.org/thread-22187-post-25384.html#pid25384

Unless I'm misreading, the unofficial file tm04o2000.dat is mis-named. I believe that LDView is behaving correctly, and the file should be named rm04o2000.dat.

The name tm04o2000.dat describes a torus with a minor radius of 0.2 LDU, not 2 LDU like this file's header comment indicates. The name rm04o2000.dat represents a torus with a minor radius of 2 LDU.

It's file name is consistent with official files:
https://www.ldraw.org/cgi-bin/ptscan.cgi?q=tm0&scope=header

It's dimensions, however, are not correct.


RE: LDView 4.4 Beta 4 test release - Travis Cobbs - 2021-06-03

(2021-06-03, 1:10)Orion Pobursky Wrote: It's file name is consistent with official files:
https://www.ldraw.org/cgi-bin/ptscan.cgi?q=tm0&scope=header

It's dimensions, however, are not correct.

Its filename is consistent with a torus with minor radius of 0.2 LDU (which is what you see in LDView with primitive substitution enabled). Since its geometry has a minor radius of 2 LDU, it seems clear that the intention was for this to be an "rm" torus instead of a "tm" torus. (Changing the first letter from t to r results in the correct filename for the geometry in the file.)

For what it's worth, I placed a hold vote on tm02o2000.dat stating that it should be named rm02o2000.dat.


RE: LDView 4.4 Beta 4 test release - Philippe Hurbain - 2021-06-03

(2021-06-03, 4:54)Travis Cobbs Wrote: For what it's worth, I placed a hold vote on tm02o2000.dat stating that it should be named rm02o2000.dat.
Agreed, primref makes it clear:
Quote:This suite of primitives are used to generate circular torus sections. By default all these primitives produce a torus with a major radius of 1LDu, so typically need to be scaled up in the {x} and {z} dimensions. The first character denotes whether the minor radius is smaller than (tff primitives) or larger than the major radius (rff primitives). The latter are termed reverse ratio tori.