LDraw.org Discussion Forums
LDInspector - Printable Version

+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: LDraw Programs (https://forums.ldraw.org/forum-7.html)
+--- Forum: LDraw Editors and Viewers (https://forums.ldraw.org/forum-11.html)
+--- Thread: LDInspector (/thread-23882.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14


RE: LDInspector - Stefan Frenz - 2020-04-04

(2020-03-20, 1:19)N. W. Perry Wrote: It would be a warning/suggestion check, rather than an error, of course. But maybe all I really wanted was the ability to select all submodels and/or assign all of them to a specific color (perhaps in LDCad's clean-up dialog).
Hi there,

the check is not implemented, but you can bulk-change referenced part colors with the current version on the Edit pane, which has a new line to change (all) color references to another one and a combined filter+set function. So if you have multiple references to a part (in the screenshot: "603-1 - sidecar.ldr"), you can filter the name and set the color (pay attention to the checkboxes on the right) and replace all colors to the selected one.

I know that this is not really what you wanted - the check is missing and there is no simple way to insert part names. I still have not an optimal feeling about setting all internal part (sub-model) references to color 16: the "parent" color during rendering does not makes sense to me here, and paths in LDCad are modeled in way that I like very much - but would prevent this type of change. If you really really really Wink  like to have this feature, I would invent a special NWPerry-button. Big Grin 

Best regards,
Stefan


RE: LDInspector - N. W. Perry - 2020-04-04

(2020-03-03, 6:35)Stefan Frenz Wrote: Speaking for Linux/MacOS versions: if your starter file changes the directory to the one the jar-file is in, you have to put your LDInspector.ldi there. But if you set all Java-paths correctly (which I have no idea for MacOS), you may start LDInspector from any directory and have another LDInspector.ldi in each one.

This worked very easily; I just put the .ldi file next to the .jar file in the same directory, and it started right up without complaint.

I am also not too sure how best to change Java paths, and not sure it's worth researching. As long as I have my starter file in the Applications folder (after all, it is itself an application), I have no trouble locating the program.

Quote:Maybe LDInspector could offer a command line option? Something like
Code:
java .... ldinsp.LDInspector -data PATH_AND_FILE.ldi
This would allow even for Windows to have multiple workspace configurations.

Shell I? Wink

I can make it work either way, but that may well be useful to others. (For one thing, it would allow me to put my workspace back into the more logical Application Support directory, rather than deep in my system library where password authentication is required.)


RE: LDInspector - N. W. Perry - 2020-04-05

(2020-04-04, 14:05)Stefan Frenz Wrote: Hi there,

the check is not implemented, but you can bulk-change referenced part colors with the current version on the Edit pane, which has a new line to change (all) color references to another one and a combined filter+set function. So if you have multiple references to a part (in the screenshot: "603-1 - sidecar.ldr"), you can filter the name and set the color (pay attention to the checkboxes on the right) and replace all colors to the selected one.

I know that this is not really what you wanted - the check is missing and there is no simple way to insert part names. I still have not an optimal feeling about setting all internal part (sub-model) references to color 16: the "parent" color during rendering does not makes sense to me here, and paths in LDCad are modeled in way that I like very much - but would prevent this type of change. If you really really really Wink  like to have this feature, I would invent a special NWPerry-button. Big Grin 

Best regards,
Stefan
 Honor though it would be, no need to go out of your way on my account.  Wink  But an exchange color feature seems handy regardless.


RE: LDInspector version 0.2 - Willy Tschager - 2020-04-08

* The installation under win was smooth but you should add a note to the wiki in case the install.bat is stored in the program folder it has to be run with admin privileges.
* I'm still confused that something like the Workspace is positioned on the left border and not the items section I work with every day
* After setting workspace for the first time it should be automatically saved (to <user>\Appdata)at the closing of the dialog.


* I used [attachment=5062] for testing - which is pure hell.
* I do not like the fact that my file is overwritten right away and that no backup is created. I would prefer a Save button, which saves all the modification at the very end.
* I don't like the order how the checks are presented. A mirrored part to me is secondary, while a correct header is key.
* 0 FILE 364 - Harbour Scene - Warehouse - String.ldr has (among other things a license issue) The quickfix confirmed that a licences has been added but didn't show up in Source. I had to load another subfile and then reload the String to get rid of the error in the OMR-check
* My .mpd will never be OMRized because of: "error: file contains sub-parts, but filename does not end with .mpd"
* Does not check for: 0 ROTATION CENTER 0 0 0 1 "Custom", 0 ROTATION CONFIG 0 0
* Does not update .mpd content after unofficial files have been imported
* FIlename of imported unofficial files is wrong.
* Complains about filename s\364 - u572p02s01.dat does not start with parent OMR prefix "364 - "

w.


RE: LDInspector version 0.2 - Stefan Frenz - 2020-04-08

(2020-04-08, 11:52)Willy Tschager Wrote: * Complains about filename s\364 - u572p02s01.dat does not start with parent OMR prefix "364 - "
Thank you very much for testing and reporting all the details, which I will look at as soon as possible. Also thank you for giving a hint for the model that is tested.

You mention the filename "s\364 - u[.]". In fact the imported files with leading pathnames I don't understand completely and therefore would assume, that the test therefore is not done correctly. With your hint, I would re-write this test and adopt the naming of inlined files.

The save-will-overwrite-thing doesn't convince me, either. I will have to completely re-design the GUI for file editing.


RE: LDInspector version 0.2 - Stefan Frenz - 2020-04-12

...had a closer look in the last days. Smile

(2020-04-08, 11:52)Willy Tschager Wrote: * The installation under win was smooth but you should add a note to the wiki in case the install.bat is stored in the program folder it has to be run with admin privileges.
* After setting workspace for the first time it should be automatically saved (to <user>\Appdata)at the closing of the dialog.
* I used 364 for testing - which is pure hell.
* I do not like the fact that my file is overwritten right away and that no backup is created. I would prefer a Save button, which saves all the modification at the very end.
* I don't like the order how the checks are presented. A mirrored part to me is secondary, while a correct header is key.
* 0 FILE 364 - Harbour Scene - Warehouse - String.ldr has (among other things a license issue) The quickfix confirmed that a licences has been added but didn't show up in Source. I had to load another subfile and then reload the String to get rid of the error in the OMR-check
I work on them, some are fixed in the current version. Especially mirrored parts are shown only once per subfile, so in your test case the output becomes readable.


(2020-04-08, 11:52)Willy Tschager Wrote: * I'm still confused that something like the Workspace is positioned on the left border and not the items section I work with every day
I'm sorry: I believe that I didn't get your point. On the left side you can place the directories and/or files you work with every day. After selecting one file, you get all functions available at the moment. Or did you mean that the Item pane should be in the middle between the selection and the functions pane? Huh

(2020-04-08, 11:52)Willy Tschager Wrote: * Does not check for: 0 ROTATION CENTER 0 0 0 1 "Custom", 0 ROTATION CONFIG 0 0
All unknown 0-lines are ignored, yes. Should there be another test to indicate non-OMR-meta lines?

(2020-04-08, 11:52)Willy Tschager Wrote: * FIlename of imported unofficial files is wrong.
Hum, I don't find one, so I guess I don't understand file constraints, yet. For example, the file "u9132c04.dat" is imported with header
Code:
0 FILE u9132c04.dat
0 ~Axle Steel  4 x  72 LDU with Two Wheels  6.4 x  8 with Tyres  3/100 x  8 Double Smooth
0 Name: u9132c04.dat
Could you please give me a hint what is wrong or what file is imported with wrong filename?

(2020-04-08, 11:52)Willy Tschager Wrote: * Does not update .mpd content after unofficial files have been imported
* Complains about filename s\364 - u572p02s01.dat does not start with parent OMR prefix "364 - "
* My .mpd will never be OMRized because of: "error: file contains sub-parts, but filename does not end with .mpd"
I wasn't able to reproduce this behavior with the current version. Could you please send me the content of ldiver.txt file in your ldinsp.jar?

Thanks again for testing, I really appreciate your feedback. Smile 
Best regards - Stefan


RE: LDInspector version 0.2 - Willy Tschager - 2020-04-12

I'll comment on the rest when I have a bit more time

(2020-04-12, 6:21)Stefan Frenz Wrote: I'm sorry: I believe that I didn't get your point. On the left side you can place the directories and/or files you work with every day. After selecting one file, you get all functions available at the moment. Or did you mean that the Item pane should be in the middle between the selection and the functions pane? Huh

[attachment=5090]

(2020-04-12, 6:21)Stefan Frenz Wrote: All unknown 0-lines are ignored, yes. Should there be another test to indicate non-OMR-meta lines?

Jepp!

w.


RE: LDInspector version 0.2 - Willy Tschager - 2020-04-12

(2020-04-12, 6:21)Stefan Frenz Wrote: Hum, I don't find one, so I guess I don't understand file constraints, yet. For example, the file "u9132c04.dat" is imported with header
Code:
0 FILE u9132c04.dat
0 ~Axle Steel  4 x  72 LDU with Two Wheels  6.4 x  8 with Tyres  3/100 x  8 Double Smooth
0 Name: u9132c04.dat
Could you please give me a hint what is wrong or what file is imported with wrong filename?

https://www.ldraw.org/article/593.html#mpd_file_structure

Unofficial parts are allowed to be used, but must be included in the MPD as referenced subfiles. The filename of the unofficial part is subject to the following naming rules:
Code:
<Set Number>[-<Optional Qualifier>] - <Unofficial Part Number>.dat
Where:

Code:
<Set Number>
is the the number printed on the model's container.

Code:
<Optional Qualifier>
is a sequential number, starting with 1, added if there is more than one set that could be assigned <Set Number>.

Code:
<Unofficial Part Number>
is the unofficial part number assigned in that very moment.
Example:

Code:
33956.dat would be renamed to 3345 - 33956.dat or 3345-1 - 33956.dat

The OMRized version of the file above can be found here.

w.


RE: LDInspector version 0.2 - Stefan Frenz - 2020-04-12

Ah, now I got it! Big Grin  So the buttons will look like this in the next version:
[attachment=5092]

The check against additional meta-lines will be included, too.


RE: LDInspector version 0.2 - Stefan Frenz - 2020-04-12

Hum, hm, uh, yes. Angel  I have to admit: my statement was misleading. For OMR-models, the names have to be in the way described in your link, and hopefully the name check detects this correctly. On the Edit pane the "inline unofficial parts" is not OMR compliant as well as the "inline unofficial parts" on the OMR-check page, at least if it is not followed by the name-compliance-check. My idea was that inlining is separated from naming - inlining just does inlining, the name-check afterwards does (should do) the renaming to OMR-compliance.

After your explanation now I see that importing unofficial files without clear statement about the name is misleading for the user. I will add an option to either inline without name change or inline with OMR-prefixing. Thanks! Smile