LDraw.org Discussion Forums
3D Part Preview added to Parts Tracker - Printable Version

+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: General (https://forums.ldraw.org/forum-12.html)
+--- Forum: LDraw.org Announcements (https://forums.ldraw.org/forum-1.html)
+--- Thread: 3D Part Preview added to Parts Tracker (/thread-23540.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11


RE: 3D Part Preview added to Parts Tracker - Orion Pobursky - 2019-07-20

(2019-07-20, 11:12)Lasse Deleuran Wrote: This, in combination with the 'half harlequin' mode turned out to be a great stress test of the geometry-optimization for the renderer. I have pushed a fix of 'js/LDRGeometries' to master.

Content of the bug fix: This diff on GitHub

I pulled the latest updates and no errors that I can see.


RE: 3D Part Preview added to Parts Tracker - Orion Pobursky - 2019-07-20

I've compensated for the extra primitives added by the setStuds method in my path prefretch script and started playing around with this.

Looks good however the rounded stud tops don't render well in the flat, non-shiny, instructions-style format. High contrast also works quite well. 

I did get a "call stack to large" when trying to render parts with lots of studs (like baseplates) in quality 4 or 5. Example:
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/10p01.dat
(Note: I have quality set at 0 on the PT so you'll have to download and use this part elsewhere to get the error)

Also, for PT purposes, can you add a non-rounded stud with line logo option?


RE: 3D Part Preview added to Parts Tracker - Magnus Forsberg - 2019-07-20

(2019-07-20, 15:07)Orion Pobursky Wrote: I pulled the latest updates and no errors that I can see.

Primitives inside the subfile gets random colours. Don't think that was wanted/intended?

[attachment=3852]

Here, the subfile is orange, and the primitives inside it is randomized.
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/22385p137.dat


RE: 3D Part Preview added to Parts Tracker - Lasse Deleuran - 2019-07-20

(2019-07-20, 15:07)Orion Pobursky Wrote: I pulled the latest updates and no errors that I can see.
Excellent. I am looking into the BFC issue not. It is regarding BFC NOCLIP. The simple 'hack' to show BFC might be a bit too simple.


RE: 3D Part Preview added to Parts Tracker - Lasse Deleuran - 2019-07-20

(2019-07-20, 15:33)Magnus Forsberg Wrote: Primitives inside the subfile gets random colours. Don't think that was wanted/intended?



Here, the subfile is orange, and the primitives inside it is randomized.
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/22385p137.dat
Ah. That makes a lot of sense. I have pushed a new sample file where only the top level sub files are given random colors:

https://github.com/LasseD/buildinginstructions.js/blob/master/test_harlequin.htm


RE: 3D Part Preview added to Parts Tracker - Orion Pobursky - 2019-07-20

(2019-07-20, 15:50)Lasse Deleuran Wrote: Ah. That makes a lot of sense. I have pushed a new sample file where only the top level sub files are given random colors:

https://github.com/LasseD/buildinginstructions.js/blob/master/test_harlequin.

Implemented. No errors

See also my comments about studs at the bottom of the thread.


RE: 3D Part Preview added to Parts Tracker - Lasse Deleuran - 2019-07-20

(2019-07-20, 15:19)Orion Pobursky Wrote: I've compensated for the extra primitives added by the setStuds method in my path prefretch script and started playing around with this.

Looks good however the rounded stud tops don't render well in the flat, non-shiny, instructions-style format. High contrast also works quite well. 

I did get a "call stack to large" when trying to render parts with lots of studs (like baseplates) in quality 4 or 5. Example:
https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/10p01.dat
(Note: I have quality set at 0 on the PT so you'll have to download and use this part elsewhere to get the error)

Also, for PT purposes, can you add a non-rounded stud with line logo option?
Are you thinking of a hard edge stud like type 1 but with the raises sides like type 4?


RE: 3D Part Preview added to Parts Tracker - Orion Pobursky - 2019-07-20

(2019-07-20, 17:57)Lasse Deleuran Wrote: Are you thinking of a hard edge stud like type 1 but with the raises sides like type 4?

No. A combo of stud.dat with logo.dat.


RE: 3D Part Preview added to Parts Tracker - Philippe Hurbain - 2019-07-21

(2019-07-20, 16:30)Orion Pobursky Wrote: See also my comments about studs at the bottom of the thread.
Overall, works great and is damn fast! But for some reason I see nothing for this part https://www.ldraw.org/cgi-bin/ptdetail.cgi?f=parts/44567a.dat (b version too)
Wish of the day: a 3d view button for official parts ....


RE: 3D Part Preview added to Parts Tracker - Lasse Deleuran - 2019-07-21

(2019-07-20, 18:12)Orion Pobursky Wrote: No. A combo of stud.dat with logo.dat.
That would be the one you get when you set the stud type to 1, right? (stud.dat is the one with square sides, while logo.dat is the single line edge draw type)

[Image: 123.png]