+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: Models and Parts (https://forums.ldraw.org/forum-18.html)
+--- Forum: Parts Authoring (https://forums.ldraw.org/forum-19.html)
+--- Thread: Question about Shock Absorber Damped (/thread-22580.html)
Question about Shock Absorber Damped - Merlijn Wissink - 2017-11-28
So, I noticed that the library contains 2 versions of 'Shock Absorder 10L Damped':
- 32181c02, trans-clear housing
- 32181c04, trans-blue housing
Isn't it more logical to remove those two shortcuts and create a new shortcut where the spring is hardcoded (black) and the housing is variable. It's way more logical when giving the part a color and it's more in line with the other springs.
I hope that makes sense
RE: Question about Shock Absorber Damped - Philippe Hurbain - 2017-11-28
Makes (lot of) sense, though the spring IS hard coded to metal color (494). The other problem is that Brickset seems to list only one color (trans clear) though some sets are clearly trans blue! (https://brickset.com/parts/design-76320). I try to know more about this...
RE: Question about Shock Absorber Damped - Magnus Forsberg - 2017-11-28
(2017-11-28, 11:36)Merlijn Wissink Wrote: Isn't it more logical to remove those two shortcuts and create a new shortcut where the spring is hardcoded (black) and the housing is variable. It's way more logical when giving the part a color and it's more in line with the other springs.
I agree in that it would have been better if it was made like the other shock absorbers, but I don't think such a replacement is backwards compatible. Wouldn't any ~Move to file, have to be fully hardcoded?
Bricklink has three versions of the same number; TrClear, TrBlue and TrClear without Spring.
RE: Question about Shock Absorber Damped - Philippe Hurbain - 2017-11-28
(2017-11-28, 18:46)Magnus Forsberg Wrote: Bricklink has three versions of the same number; TrClear, TrBlue and TrClear without Spring.I had a look at my parts, the springs ar different between blue and clear versions. I was not aware of springless version, but indeed: https://brickset.com/parts/design-63144
RE: Question about Shock Absorber Damped - Merlijn Wissink - 2017-11-29
(2017-11-28, 19:47)Philippe Hurbain Wrote:(2017-11-28, 18:46)Magnus Forsberg Wrote: Bricklink has three versions of the same number; TrClear, TrBlue and TrClear without Spring.I had a look at my parts, the springs ar different between blue and clear versions. I was not aware of springless version, but indeed: https://brickset.com/parts/design-63144
Wow, a springless version? Didn't know that either. I looked up some (video) reviews of that set and it's indeed without spring. Weird.
The reason I started this topic was because Rebrickable is having a bit of trouble with this part (as far as LDraw export/import is concerned). When there's no image available for a part, it uses a generated image from LDraw parts (if possible). For this part however, things get a little messed up. First problem is that Rebrickable can't handle specific parts for specific colors. In this case, only the trans-clear LDraw part is mapped to the Rebrickable part (which contains both tr-clear and tr-blue). Second problem is that the images that are generated are wrong too. Instead of a tr-clear housing and tr-blue housing, you get images with a tr-clear housing + tr-clear inside and a tr-clear housing + a tr-blue inside. If that makes sense
RE: Question about Shock Absorber Damped - Philippe Hurbain - 2017-12-05
(2017-11-29, 7:55)Merlijn Wissink Wrote:(2017-11-28, 19:47)Philippe Hurbain Wrote: I had a look at my parts, the springs ar different between blue and clear versions. I was not aware of springless version, but indeed: https://brickset.com/parts/design-63144
Wow, a springless version? Didn't know that either. I looked up some (video) reviews of that set and it's indeed without spring. Weird.
The reason I started this topic was because Rebrickable is having a bit of trouble with this part (as far as LDraw export/import is concerned). When there's no image available for a part, it uses a generated image from LDraw parts (if possible). For this part however, things get a little messed up. First problem is that Rebrickable can't handle specific parts for specific colors. In this case, only the trans-clear LDraw part is mapped to the Rebrickable part (which contains both tr-clear and tr-blue). Second problem is that the images that are generated are wrong too. Instead of a tr-clear housing and tr-blue housing, you get images with a tr-clear housing + tr-clear inside and a tr-clear housing + a tr-blue inside. If that makes sense
Hopefully OK now: http://www.ldraw.org/cgi-bin/ptscan.cgi?q=damped. Previous obsoletized shortcuts are sent to admin.
What was done:
- modified body and piston shortcuts to use correct colors and changed origin to Technic pin hole.
- generated new springs with correct winding (previous version was turning backwards) in compressed and extended versions. Extended is 4ldu longer to fit physcal dimension of extended shock absorber
- Generated new shortcuts using assembly design numbers (from Brickset) with and without spring, extended and compressed
- Though I have two different versions of spring I kept things simple (and made only one) as they seem completely equivalent (same stiffness)
RE: Question about Shock Absorber Damped - Merlijn Wissink - 2017-12-06
(2017-12-05, 13:23)Philippe Hurbain Wrote: Hopefully OK now: http://www.ldraw.org/cgi-bin/ptscan.cgi?q=damped. Previous obsoletized shortcuts are sent to admin.
What was done:
- modified body and piston shortcuts to use correct colors and changed origin to Technic pin hole.
- generated new springs with correct winding (previous version was turning backwards) in compressed and extended versions. Extended is 4ldu longer to fit physcal dimension of extended shock absorber
- Generated new shortcuts using assembly design numbers (from Brickset) with and without spring, extended and compressed
- Though I have two different versions of spring I kept things simple (and made only one) as they seem completely equivalent (same stiffness)
Nice work! You seem to have taken an extra good look at the parts instead of just renaming/recoloring the stuff, haha. Everything looks fine to me. Thanks!
