LDraw.org Discussion Forums
New Parts for LGEO Library - Printable Version

+- LDraw.org Discussion Forums (https://forums.ldraw.org)
+-- Forum: LDraw Programs (https://forums.ldraw.org/forum-7.html)
+--- Forum: Rendering Techniques (https://forums.ldraw.org/forum-20.html)
+--- Thread: New Parts for LGEO Library (/thread-16260.html)

Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25


RE: New Parts for LGEO Library - Michael Horvath - 2019-07-09

I am running into issues with some of the parts.

"lg_0069.inc" is trying to include "69.inc" but I cannot find the latter file anywhere.

There are a few more parts that do this too.


RE: New Parts for LGEO Library - Damien Roux - 2019-07-09

(2019-07-09, 1:48)Michael Horvath Wrote: I am running into issues with some of the parts.

"lg_0069.inc" is trying to include "69.inc" but I cannot find the latter file anywhere.

There are a few more parts that do this too.

If you can give a list of those, I will make the corrections.


RE: New Parts for LGEO Library - Michael Horvath - 2019-07-10

(2019-07-09, 21:39)Damien Roux Wrote: If you can give a list of those, I will make the corrections.

I included every one of your parts, and these were the issues that cropped up:

Code:
69.inc    missing file
70.inc    missing file
481.inc    missing file
482.inc    missing file
lg_metallic_dark_grey    missing color
168275a.inc    missing file
168295a.inc    missing file
192425.inc    missing file
LDXColor322    missing color
2684s01a.inc    missing file
2684s01b.inc    missing file
2837.inc    missing file
2986c01a.inc    missing file
2986c01b.inc    missing_file
2986c01c.inc    missing_file
lego_logo_text_tech    missing object
192425.inc    missing file
LDXColor128    missing color
3678.inc    missing file
3957.inc    missing file
3962.inc    missing file
4032.inc    missing file
4151.inc    missing file
4220.inc    missing file
4617.inc    missing file
4755a.inc    missing file
4755b.inc    missing file
4757a.inc    missing file
4757b.inc    missing file
4758a.inc    missing file
4758b.inc    missing file
4768a.inc    missing file
4768b.inc    missing file
4768c.inc    missing file
4768d.inc    missing file
4772a.inc    missing file
4772b.inc    missing file
4772c.inc    missing file
4772d.inc    missing file
4772e.inc    missing file
4773aa.inc    missing file
4773ab.inc    missing file
4774a.inc    missing file
4774b.inc    missing file
4865.inc    missing file
4869.inc    missing file
48729.inc    missing file
5306aa.inc    missing file
5306ab.inc    missing file
Studela.inc    missing file
Studelb.inc    missing file



RE: New Parts for LGEO Library - LDView colors - Michael Horvath - 2019-07-10

I noticed that you (ed. Damien) put some of the LDXColorNNN references within the parts themselves. I see why you did this, but don't think it is a good idea. These colors are specific to LDView, and other tools won't know what to do.


RE: New Parts for LGEO Library - parts naming inconsistencies - Michael Horvath - 2019-07-10

I notice that some LDraw part names get padded with zeros when creating LGEO versions.

For instance, LDraw uses these names for some parts:

Code:
1.dat
10.dat
100.dat

Lutz then padded the names with zeros (as well as added a prefix and changed the extension) to get:

Code:
lg_0001.inc
lg_0010.inc
lg_0100.inc

But not everyone does this consistently. Owen did not pad any of his parts names with zeros. Some of Damien's parts names are padded, others are not padded. I think we should decide whether it is important to do this consistently, or possibly even whether we should do it at all. (The padding makes writing some scripts harder than simply reusing the original LDRaw file names. For instance, in MS Excel, adding and removing the zeros is difficult and messy.)

Opinions?


RE: New Parts for LGEO Library - Damien Roux - 2019-07-10

I've updated my package and my lgeo.xml with the following :

69.inc missing file : Obsolete part : Corrected
70.inc missing file : Obsolete part : Corrected
481.inc missing file : Obsolete part : Corrected
482.inc missing file : Obsolete part : Corrected
lg_metallic_dark_grey missing color : lg_color_LDX_L3P.inc updated
168275a.inc missing file : Sticker : Removed (wasn't defined in the lgeo.xml)
168295a.inc missing file : Sticker : Removed (wasn't defined in the lgeo.xml)
192425.inc missing file : Sticker : Removed (wasn't defined in the lgeo.xml)
LDXColor322 missing color : lg_color_LDX_L3P.inc updated
2684s01a.inc missing file : Not needed anymore : Removed
2684s01b.inc missing file : Not needed anymore : Removed
2837.inc missing file : Obsolete part : Corrected
2986c01a.inc missing file : Not needed anymore : Removed
2986c01b.inc missing_file : Not needed anymore : Removed
2986c01c.inc missing_file : Not needed anymore : Removed
lego_logo_text_tech missing object : Could you tell me which part cause this problem?
192425.inc missing file : Sticker : Removed (wasn't defined in the lgeo.xml)
LDXColor128 missing color : lg_color_LDX_L3P.inc updated
3678.inc missing file : Obsolete part : Corrected
3957.inc missing file : Obsolete part : Corrected
3962.inc missing file : Obsolete part : Corrected
4032.inc missing file : Obsolete part : Corrected
4151.inc missing file : Obsolete part : Corrected
4220.inc missing file : Obsolete part : Corrected
4617.inc missing file : Obsolete part : Corrected
4755a.inc missing file : Not needed anymore : Removed
4755b.inc missing file : Not needed anymore : Removed
4757a.inc missing file : Not needed anymore : Removed
4757b.inc missing file : Not needed anymore : Removed
4758a.inc missing file : Not needed anymore : Removed
4758b.inc missing file : Not needed anymore : Removed
4768a.inc missing file : Not needed anymore : Removed
4768b.inc missing file : Not needed anymore : Removed
4768c.inc missing file : Not needed anymore : Removed
4768d.inc missing file : Not needed anymore : Removed
4772a.inc missing file : Not needed anymore : Removed
4772b.inc missing file : Not needed anymore : Removed
4772c.inc missing file : Not needed anymore : Removed
4772d.inc missing file : Not needed anymore : Removed
4772e.inc missing file : Not needed anymore : Removed
4773aa.inc missing file : Not needed anymore : Removed
4773ab.inc missing file : Not needed anymore : Removed
4774a.inc missing file : Not needed anymore : Removed
4774b.inc missing file : Not needed anymore : Removed
4865.inc missing file : Obsolete part : Corrected
4869.inc missing file : File is existing, don't see where the error is
48729.inc missing file : Obsolete part : Corrected
5306aa.inc missing file : Not needed anymore : Removed
5306ab.inc missing file : Not needed anymore : Removed
Studela.inc missing file : Not needed anymore : Removed
Studelb.inc missing file : Not needed anymore : Removed


Could you check if you don't have any missing file anymore?
Thanks a lot for pointing these out!



Also :
* As of 2019/07/01, the official AIOI seems to include Owen's parts but not Damien's parts. : True!
* As of 2019/07/01, the latest LGEO parts by Damien are missing "lg_2345p44.inc" and "lg_3794a.inc", even though they are listed in his "LGEO.xml". : Parts have been created and are ready for my next release.
* The LGEO files "lg_10197.inc", "lg_10288.inc" and "lg_85940.inc" reference an object named "lg_tech_tube", but this object is not missing from Damien's "lg_defs.inc". : Parts have been created and are ready for my next release. So no more need of "lg_tech_tube".
* As of 2019/07/01, in Damien's version of "LGEO.xml" color 406 "lg_rubber_dark_purple" should be renamed to "lg_rubber_dark_blue" (or vice versa, I'm not entirely sure). : I don't know either. : Renamed to "lg_rubber_dark_blue"
* In the LGEO library, ABS and PC plastic parts do not have any normals. Parts made of other materials (e.g. rubber, pearl, chrome, transparent) do have normals, however. : I have attached my personnal "lg_color.inc" file which should correct that. Please be careful because I have tweaked the colors to suit my personnal taste, they are not defined based on whatever color chart. Be aware of that.
* By default, sloped parts don't have alternative normals, despite that the sloped parts themselves have always supported this feature. Some programs add normals to these parts, however. : I have attached my personnal "lg_color.inc" file which should correct that. Please be careful because I have tweaked the colors to suit my personnal taste, they are not defined based on whatever color chart. Be aware of that.
* As of 2019/07/01, the latest version of LGEO's "lg_color.inc" file is missing many colors, such as "color 495 - Electric_Contact_Copper" and "color 339 - Glitter_Trans_Neon_Green". This file needs to be updated to reflect the most current "LDConfig.ldr" file. My lg_color.inc" file should have a bit more of them.
* LGEO materials do not support SSLT or blurred reflections. : Be careful with that as it will signifiquently increase the rendering time with PovRay, which already not really fast. But it needs to be studied.
* In Owen's LGEO library the part "lg_756" is listed twice in "LGEO.xml". I have it on my library as "lg_0756", so it might not be needed anymore.
* "LDConfig.ldr" treats Glow_In_Dark_Opaque, Milky_White, Glow_In_Dark_Trans and Glow_In_Dark_White as partially transparent. LGEO treats some of these as fully solid. It might be a bit different in my "lg_color" definition
* It might be better to remove the zero padding from all LGEO part names so that they match the original LDraw part names. The padding serves no real purpose as far as I can tell, and just makes things a little bit more confusing for everyone. Even if I've used zeros for less than 4 digit part numbers, I would 100% agree to remove them.
* Should LGEO part names all be lower case? Should LGEO part names match the case of the original LDraw part names? Does it matter? Yes, I would put lower cases everywhere even if PovRay is not case-sensitve with ".inc" files



RE: New Parts for LGEO Library - LDView colors - Damien Roux - 2019-07-10

(2019-07-10, 21:47)Michael Horvath Wrote: I noticed that you (ed. Damien) put some of the LDXColorNNN references within the parts themselves. I see why you did this, but don't think it is a good idea. These colors are specific to LDView, and other tools won't know what to do.

I agree with you, but I've never thought about another way to do it. Also, original parts from Lutz where also embedding colors like this, as far as I remember.


RE: New Parts for LGEO Library - parts naming inconsistencies - Damien Roux - 2019-07-10

(2019-07-10, 22:12)Michael Horvath Wrote: I notice that some LDraw part names get padded with zeros when creating LGEO versions.

For instance, LDraw uses these names for some parts:

Code:
1.dat
10.dat
100.dat

Lutz then padded the names with zeros (as well as added a prefix and changed the extension) to get:

Code:
lg_0001.inc
lg_0010.inc
lg_0100.inc

But not everyone does this consistently. Owen did not pad any of his parts names with zeros. Some of Damien's parts names are padded, others are not padded. I think we should decide whether it is important to do this consistently, or possibly even whether we should do it at all. (The padding makes writing some scripts harder than simply reusing the original LDRaw file names. For instance, in MS Excel, adding and removing the zeros is difficult and messy.)

Opinions?

100% agree on removing the first "0", I could rework my parts and lgeo.xml in this way.
I've used the same "rule" as Lutz, have at least 4 characters, so every part bellow 999 begins with "0".


RE: New Parts for LGEO Library - parts naming inconsistencies - Michael Horvath - 2019-07-11

(2019-07-10, 23:53)Damien Roux Wrote: 100% agree on removing the first "0", I could rework my parts and lgeo.xml in this way.
I've used the same "rule" as Lutz, have at least 4 characters, so every part bellow 999 begins with "0".

Removing the zeros from all the files will take some work. I can create a Python script to do it I think. I will start with Lutz's parts.


RE: New Parts for LGEO Library - Michael Horvath - 2019-07-11

(2019-07-10, 23:46)Damien Roux Wrote: lego_logo_text_tech missing object : Could you tell me which part cause this problem?

These files:
lg_30359a.inc
lg_30359b.inc
lg_30361a.inc

(2019-07-10, 23:46)Damien Roux Wrote: 4869.inc missing file : File is existing, don't see where the error is

Oops! The file is not missing. However, it is looking for an object called lego_logo_text which it can't find.