LDraw.org Discussion Forums

Full Version: CRLF as official line ending
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
Allen Smith Wrote:I also don't see why the file should be required to end in a newline.

Your statement here is a lot less strong than the one in your NO vote. If you had said here that BrickSmith has always omitted that final newline, I think it would have led to some discussion.

To be honest, I don't have a strong opinion of the final newline. Somewhat ironically, though, text files with no EOL at the end were historically considered to be bad in Unix. In fact, vi gives a notice when such a file is loaded, and is itself incapable of creating such files (or if it is possible, you have to jump through hoops). And text files in DOS often skipped the final newline.

I haven't yet responded to Willy's Call for Votes because of the reason you gave in your NO vote. I'd like to see what others think here.
Travis Cobbs Wrote:Your statement here is a lot less strong than the one in your NO vote. If you had said here that BrickSmith has always omitted that final newline, I think it would have led to some discussion.

Yeah, that's entirely my fault and I apologize. I don't think I realized what I had implemented when I wrote the post you quoted (I wrote that code 7 years ago and haven't touched it since). Once I looked it up and realized what I'd done, I had meant to bring it up here. But I hadn't gotten around to it yet.

If everybody else voted yes I wouldn't be angry and I'll update my software. But I do disagree with the final newline requirement. I think it's unnecessarily restrictive, and I think software authors need to accept files with or without a final newline in a user-editable text-based format. I also have somewhat unwittingly given myself a vested interest in voting against it, so vote against it I did. (Sorry! Nothing personal!)

Allen
Pages: 1 2