LDraw.org Discussion Forums

Full Version: Part 32289b modifications and new parts
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Pages: 1 2
(2021-03-05, 14:41)Willy Tschager Wrote: [ -> ]Javier,

looks good to me, presuming you add the missing edges such as these:

2 4 -22 74 32 -22 96 32
2 4 -17.48 74.78 60 -17.74 76 60
2 4 0 48 -205.125 -6.1232 49.2176 -205.125
2 4 6.1232 49.2176 -205.125 0 48 -205.125

...

or eliminating these:

2 24 0 44 -78.875 0 48 -78.875
2 24 -36 44 -78.875 -36 48 -78.875
...

* Also the whole naming with the missing s\ has to be fixed.

* I cannot see any reason for not inlining s\32289as02.dat or s\32289bs02.dat (which BTW is almost coming through the surface) into the main part a and b.

* It is clear to me that you're a very talented part author for the simple fact that you have the courage to tackle such a monster but I still don't get your tendency for T-Junctions such as this:

4 4 -34 92 31 -34 92 28 -22 92 28 -22 92 31
4 4 -36 92 28 -34 92 28 -34 92 30 -36 92 30
4 4 -36 92 28 -36 92 13 0 92 13 0 92 28
4 4 -16 92 13 -16 92 8 0 92 8 0 92 13
4 4 -16 92 8 -16 92 -13 0 92 -13 0 92 8
4 4 -40 92 8 -40 92 -13 -32 92 -13 -32 92 8
4 4 -36 92 13 -36 92 8 -32 92 8 -32 92 13


which I would build with this code:

4 1 -32 92 13 -34 92 30 -36 92 30 -36 92 13
4 1 -22 92 28 -34 92 30 -32 92 13 -16 92 13
4 1 -22 92 28 -16 92 13 0 92 13 0 92 28
4 1 -36 92 8 -40 92 8 -40 92 -13 -32 92 -13
4 1 -34 92 30 -22 92 28 -22 92 31 -34 92 31
4 1 -16 92 13 -16 92 -13 0 92 -13 0 92 13
4 1 -36 92 13 -36 92 8 -32 92 -13 -32 92 13


Just out of curiosity. What tools are you using for authoring?

w.

  1. About the inlining: Are you suggesting to add the missing edges to the primary subfile 32289s01?
  2. "The whole naming with the missing s\": it's the 32289s01 or another file?
  3. Thank you for your words but I don't think I'm talented; I just trying to correct something bad. The t-junction problem: if it is the s\32289as01, honestly, it's a copy and paste from the already submitted s/32289as01, with the corresponding deletions and minor adjustments.
Almost forgot: I use LDPE
(2021-03-05, 18:21)Javier Orquera Wrote: [ -> ]
  1. About the inlining: Are you suggesting to add the missing edges to the primary subfile 32289s01?
  2. "The whole naming with the missing s\": it's the 32289s01 or another file?
  3. Thank you for your words but I don't think I'm talented; I just trying to correct something bad. The t-junction problem: if it is the s\32289as01, honestly, it's a copy and paste from the already submitted s/32289as01, with the corresponding deletions and minor adjustments.
Almost forgot: I use LDPE

1. The edges go, where they belong. These:

2 3 -56 60 -165 -56 60 -145
2 3 -56 60 -145 -56 60 -125
2 3 -56 60 -125 -56 60 -105
2 3 -56 60 -105 -56 60 -90
2 3 -56 60 -90 -56 60 -75
2 3 -56 60 -75 -56 60 -68
2 3 -6.1232 49.2176 -205.125 0 48 -205.125

go to 32289s01.dat

This:

2 2 -17.48 74.78 60 -17.74 76 60

goes to s\32289as01.dat (BTW there is an empty comment "0" right at the start of the edges section which has to be deleted).


2. https://www.ldraw.org/part-number-spec.html#subparts

The subparts are missing a "s\" in the part name "0 Name: s\32289s01.dat", the parts itself miss the s\ in the reference:

1 16 0 0 0 1 0 0 0 1 0 0 0 1 s\32289s01.dat

3. As you use LDPE did you try resolving your T-Junk with "Actions... > Merge To Last Selected Vertex (STRG+E)"? Do you run "Tools... > Edger2" to find your missing edges an conds?

w.
Here it is the files with the changes.
(2021-03-08, 2:32)Javier Orquera Wrote: [ -> ]Here it is the files with the changes.

Overall structure looks good to me. Submit to the PT. This is not the place to review. Just one thing:

32289as01.dat

* Misses a lot of edges:

2 4 -20 74 54 -20 74 48
2 4 -20 74 48 -22 74 48
2 4 -20 74 54 -20 78 54
2 4 -20 78 54 -20 78 56

or conds

5 9 -17.48 74.78 60 -17.48 74.78 56 -17.74 76 60 -13.3 68.7 60

* Things like these:

4 9 -22 96 30 -22 96 32 -20 96 32 -20 96 30
4 9 -20 96 32 -20 74 32 -20 74 30 -20 96 30
4 9 -20 96 32 -22 96 32 -22 74 32 -20 74 32
4 2 -20 78 54 -15 78 54 -15 74 54 -20 74 54
4 2 -20 78 56 -15 78 56 -15 78 54 -20 78 54
4 2 -15 78 56 -15 74 56 -15 74 54 -15 78 54

could be boxed. https://www.ldraw.org/library/primref/#rect3d

* You should run it through "Rectifier" prior submission

32289bs01.dat

* There's a gap:

2 4 -40 45.4443 31.69 -40 45.4443 31.6849

* The cutout 1 16 0 92 37.7 0 0 -6.55 4 0 0 0 1 0 1-4disc.dat is a thick as the bottom itself. The thickness of the remaining structure would be zero.

* Excellent work on all the T-Junk but there is still room for improvement:

2 31 -22 92 37.7 -11.5 92 37.7
2 31 -11.5 92 22 -4.63 92 22
2 31 -26 96 60 -22 96 60

w.
Proposed new structure of these motors.
I'm not sure of the red partnumbers. Since the uncoloured part is 32288, maybe the assembly should use that number as base.

[attachment=6697]
Magnus Forsberg Wrote:Proposed new structure of these motors.
I'm not sure of the red partnumbers. Since the uncoloured part is 32288, maybe the assembly should use that number as base.

I'm somewhat sceptic to this scheme as:

* 32288c01.dat - Electric Technic Motor 4.5V  6 x 17 x  5 with Dark Grey Base Type 1

is used only in one set and exclusively in Dark Grey

https://lego.brickinstructions.com/08000/8472/081.jpg

* 32288c02.dat - Electric Technic Motor 4.5V  6 x 17 x  5 with Light Grey Base Type 2

is used only in three sets and exclusively in Light Grey

https://lego.brickinstructions.com/05000/5221/003.jpg
https://lego.brickinstructions.com/08000/8279/010.jpg
https://lego.brickinstructions.com/08000/8307/004.jpg

w.
Ok,
Then maybe skip the middle assembly.
I want to see the top level contaning: only the movable and removable parts + a complete assemby of the non-moving body parts.

Think animation. As a user, I want to inline the top level shortcut, and then flick the switch or rotate an axle.
Pages: 1 2